Rename ResolvedTarget to ResolvedModule
#7459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has no impact on how these concepts are named in user-visible APIs like `PackageDescription` and `PackagePlugin`, target there can stay as "target" for as long as needed. With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target.
MaxDesiatov
added
no functional change
…xd/resolved-module # Conflicts: # Sources/PackageGraph/ModulesGraph.swift
|
@swift-ci test |
xedin
approved these changes
Apr 15, 2024
| @@ -28,7 +28,7 @@ package final class ClangTargetBuildDescription { | |||
| package let package: ResolvedPackage | |||
|
|
|||
| /// The target described by this target. | |||
| package let target: ResolvedTarget | |||
| package let target: ResolvedModule | |||
There was a problem hiding this comment.
Nit: looks like the comment needs updating as well :)
| @@ -49,7 +49,7 @@ package final class ProductBuildDescription: SPMBuildCore.ProductBuildDescriptio | |||
| var additionalFlags: [String] = [] | |||
|
|
|||
| /// The list of targets that are going to be linked statically in this product. | |||
| var staticTargets: [ResolvedTarget] = [] | |||
| var staticTargets: [ResolvedModule] = [] | |||
There was a problem hiding this comment.
Would this be updated in a follow-up?
| @@ -33,7 +33,7 @@ package final class SwiftTargetBuildDescription { | |||
| package let package: ResolvedPackage | |||
|
|
|||
| /// The target described by this target. | |||
| package let target: ResolvedTarget | |||
| package let target: ResolvedModule | |||
There was a problem hiding this comment.
Nit: Same comment issue here.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
### Motivation: With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target. ### Modifications: Renamed `ResolvedTarget` to `ResolvedModule`. Added a deprecated `typealias ResolvedTarget = ResolvedModule` to allow graceful migration for users of this type. ### Result: Confusion between target triples and package targets is reduced. This has no impact on how these concepts are named in user-visible APIs like `PackageDescription` and `PackagePlugin`, target there can stay as "target" for as long as needed. Remaining internal uses of "target" outside of "target triple" context, like `*TargetBuildDescription` will be renamed in future PRs.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
### Motivation: With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target. ### Modifications: Renamed `ResolvedTarget` to `ResolvedModule`. Added a deprecated `typealias ResolvedTarget = ResolvedModule` to allow graceful migration for users of this type. ### Result: Confusion between target triples and package targets is reduced. This has no impact on how these concepts are named in user-visible APIs like `PackageDescription` and `PackagePlugin`, target there can stay as "target" for as long as needed. Remaining internal uses of "target" outside of "target triple" context, like `*TargetBuildDescription` will be renamed in future PRs.
xedin
pushed a commit
to xedin/swift-package-manager
that referenced
this pull request
May 16, 2024
With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target. Renamed `ResolvedTarget` to `ResolvedModule`. Added a deprecated `typealias ResolvedTarget = ResolvedModule` to allow graceful migration for users of this type. Confusion between target triples and package targets is reduced. This has no impact on how these concepts are named in user-visible APIs like `PackageDescription` and `PackagePlugin`, target there can stay as "target" for as long as needed. Remaining internal uses of "target" outside of "target triple" context, like `*TargetBuildDescription` will be renamed in future PRs. (cherry picked from commit 27996b8)
xedin
pushed a commit
to xedin/swift-package-manager
that referenced
this pull request
May 16, 2024
With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target. Renamed `ResolvedTarget` to `ResolvedModule`. Added a deprecated `typealias ResolvedTarget = ResolvedModule` to allow graceful migration for users of this type. Confusion between target triples and package targets is reduced. This has no impact on how these concepts are named in user-visible APIs like `PackageDescription` and `PackagePlugin`, target there can stay as "target" for as long as needed. Remaining internal uses of "target" outside of "target triple" context, like `*TargetBuildDescription` will be renamed in future PRs. (cherry picked from commit 27996b8)
xedin
added a commit
that referenced
this pull request
May 17, 2024
- Explanation: With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target. Renamed `ResolvedTarget` to `ResolvedModule`. Added a deprecated `typealias ResolvedTarget = ResolvedModule` to allow graceful migration for users of this type. Confusion between target triples and package targets is reduced. This has no impact on how these concepts are named in user-visible APIs like `PackageDescription` and `PackagePlugin`, target there can stay as "target" for as long as needed. Remaining internal uses of "target" outside of "target triple" context, like `*TargetBuildDescription` will be renamed in future PRs. - Scope: NFC change - Main Branch PRs: #7459 - Risk: Very Low - Reviewed By: @bnbarham - Testing: No new tests are necessary (cherry picked from commit 27996b8) Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
With host/target triples separation in the SwiftPM codebase, it gets very confusing whether at a given moment "target" refers to a module, a triple, or a low level build system target.
Modifications:
Renamed
ResolvedTargettoResolvedModule. Added a deprecatedtypealias ResolvedTarget = ResolvedModuleto allow graceful migration for users of this type.Result:
Confusion between target triples and package targets is reduced.
This has no impact on how these concepts are named in user-visible APIs like
PackageDescriptionandPackagePlugin, target there can stay as "target" for as long as needed.Remaining internal uses of "target" outside of "target triple" context, like
*TargetBuildDescriptionwill be renamed in future PRs.