improve diagnostics when registry configuration is broken #6331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: better user experience changes: catch the JSON error and wrap it with a more detailed diagnostics
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
yim-lee
approved these changes
Mar 25, 2023
MaxDesiatov
changed the title
MaxDesiatov
reviewed
Mar 26, 2023
MaxDesiatov
reviewed
Mar 26, 2023
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Contributor
Author
|
@swift-ci smoke test |
MaxDesiatov
approved these changes
Mar 27, 2023
Contributor
|
@swift-ci test windows |
neonichu
approved these changes
Mar 27, 2023
Contributor
Author
|
@swift-ci smoke test windows |
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Mar 27, 2023
…6331) motivation: better user experience changes: catch the JSON error and wrap it with a more detailed diagnostics Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: better user experience
changes: catch the JSON error and wrap it with a more detailed diagnostics