Replace SwiftDriverExecutor with SPMSwiftDriverExecutor #2946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenv
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci test |
|
@swift-ci please test self hosted |
1 similar comment
|
@swift-ci please test self hosted |
|
@swift-ci please smoke test |
DougGregor
approved these changes
Sep 21, 2020
|
|
||
| try job.verifyInputsNotModified(since: recordedInputModificationDates, | ||
| fileSystem: fileSystem) | ||
| assert(!job.requiresInPlaceExecution, |
There was a problem hiding this comment.
I don't see how this can fail now, but it seems fragile. Should we throw an error here rather than crash, given the likelihood that someone can slip an argument through to the Swift driver that would cause in-place execution? Crashing SwiftPM seems unfortunate there.
There was a problem hiding this comment.
Good idea! I changed this to throw an error instead
SPM does not need or use the full functionality of SwiftDriverExecutor, which we're planning to move to a separate library so that the SwiftDriver planning lib no longer depends on LLBuild. Introduce a miinimal SPMSwiftDriverExecutor for the processes the integrated driver needs to launch during planning.
owenv
force-pushed
the
driver-library-split
branch
from
0fd6eca to
2248570
Compare
|
@swift-ci smoke test |
|
@DougGregor do you mind helping merge this when you have a chance? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPM does not need or use the full functionality of SwiftDriverExecutor, which we're planning to move to a separate library so that the SwiftDriver planning library no longer depends on LLBuild. Introduce a minimal SPMSwiftDriverExecutor for the processes the integrated driver needs to launch during planning.