Extract everything depending on LLBuild into a SwiftDriverExecution library #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to make sure I didn't completely break anything... @swift-ci please test |
DougGregor
approved these changes
Sep 20, 2020
|
I've now tested the CMake build locally and everything seemed to work, so once swiftlang/swift-package-manager#2946 is merged I'll run the full test suite with this PR and then it should be mergeable. |
owenv
changed the title
|
Very excited for this to land :) |
…ibrary - Moved llbuild.Swift and the SwiftDriverExecutor into the new library - Avoid reexporting llbuildSwift through the new library - Update SPM and CMake builds
owenv
force-pushed
the
library-split
branch
from
756a6ff to
07caf40
Compare
|
Full swift-ci passed (swiftlang/swift#34040), so this should be good to go! @swift-ci test |
|
Fantastic, go for it once CI completes! |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 24, 2020
No longer needed with swiftlang#263
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Sep 25, 2020
No longer needed with swiftlang#263
xymus
pushed a commit
to xymus/swift-driver
that referenced
this pull request
Nov 6, 2020
No longer needed with swiftlang#263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP because I'm guessing I won't get the CMake changes right on the first try and I still need to update SPM. This should hopefully make #246 and related changes simpler, although splitting the libraries is a bit of a pain in the short term.