[6.0] Resolved an arithmetic overflow error in Decimal division caused by improper upcasting (#850) #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by improper upcasting (swiftlang#850) - Upcast numbers to higher bitwidth before performing calculations. resolves: rdar://133458109 resolves: swiftlang#595
itingliu
approved these changes
Aug 16, 2024
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: resolves an arithmetic overflow error in Decimal division that can lead to crash with specific inputs.
Scope: Only impact Decimal division
Original PR: #850
Risk: Minimal - scope is very small (one line)
Testing: Testing done via swift-ci testing and local testing
Reviewer: @jmschonfeld