Skip to content

Resolved an arithmetic overflow error in Decimal division caused by improper upcasting #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iCharlesHu
Copy link
Contributor

Upcast numbers to higher bitwidth before performing calculations.

resolves: rdar://133458109
resolves: #595

…mproper upcasting

- Upcast numbers to higher bitwidth before performing calculations.

resolves: rdar://133458109
resolves: swiftlang#595
@iCharlesHu iCharlesHu marked this pull request as ready for review August 14, 2024 17:55
@iCharlesHu
Copy link
Contributor Author

@swift-ci please test

@iCharlesHu iCharlesHu merged commit 0ffd606 into swiftlang:main Aug 14, 2024
3 checks passed
@iCharlesHu iCharlesHu deleted the charles/fix-decimal-division-crash branch August 14, 2024 20:48
iCharlesHu added a commit to iCharlesHu/swift-foundation that referenced this pull request Aug 16, 2024
…d by improper upcasting (swiftlang#850)

- Upcast numbers to higher bitwidth before performing calculations.

resolves: rdar://133458109
resolves: swiftlang#595
iCharlesHu added a commit that referenced this pull request Aug 17, 2024
cthielen pushed a commit to cthielen/swift-foundation that referenced this pull request Nov 8, 2024
…mproper upcasting (swiftlang#850)

- Upcast numbers to higher bitwidth before performing calculations.

resolves: rdar://133458109
resolves: swiftlang#595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSDecimalDivide() crashes on Linux with certain inputs
2 participants