[6.0] Use fallback home directory on Windows #862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use %SystemDrive\Users\Public as fallback home directory on Windows * Update to ALLUSERSPROFILE * Fix test failure * Fix iOS test failure
|
@swift-ci please test |
itingliu
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Restores Swift 5.10 behavior for getting a home directory for a non-existent user on Windows (using a reasonable default rather than asserting)
Scope: Only impacts looking up home directories for non-existent users on Windows and turns a crash into a successful return value
Original PR: #854
Risk: Minimal - scope is very small and it restores pre-recore behavior
Testing: Testing done via swift-ci testing and local testing
Reviewer: @compnerd @iCharlesHu