Use fallback home directory on Windows #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
reviewed
Aug 15, 2024
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test |
iCharlesHu
approved these changes
Aug 16, 2024
jmschonfeld
added a commit
to jmschonfeld/swift-foundation
that referenced
this pull request
Aug 16, 2024
* Use %SystemDrive\Users\Public as fallback home directory on Windows * Update to ALLUSERSPROFILE * Fix test failure * Fix iOS test failure
jmschonfeld
added a commit
that referenced
this pull request
Aug 16, 2024
cthielen
pushed a commit
to cthielen/swift-foundation
that referenced
this pull request
Nov 8, 2024
* Use %SystemDrive\Users\Public as fallback home directory on Windows * Update to ALLUSERSPROFILE * Fix test failure * Fix iOS test failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS/Linux, when asking for the home directory of a user that doesn't exist, we fallback to
/var/empty- we also have a handful of unit tests in swift-corelibs-foundation that verify this behavior. However, on Windows we currently crash with afatalErrorwhen provided a non-existent user name. swift-corelibs-foundation previously defaulted to/var/emptyon Windows too, but that directory doesn't make sense on Windows. Instead, we standardize on a fallback of%SystemDrive%\Users\Publicfor users that don't exist which is still a valid directory and is close enough to the macOS/Linux semantics despite not having a direct equivalent to/var/empty