Fix hard-coded path to FoundationEssentialsTests resources
#855
Conversation
|
swiftlang/swift-package-manager#7883 |
|
Looks like Windows failed because this change isn't compatible with older versions of SwiftPM (note: this repo does not support cross-repo testing, tests are run using the SwiftPM from the most recent nightly toolchain) |
|
@jmschonfeld I triggered Windows CI in my swift PR, if that passes we should be good to go. |
@xedin that won't be sufficient here I'm afraid. This package needs to build with the latest nightly toolchain because that's what our CI currently uses and what we use to develop at desk. We need a solution here that will work both with your change and without - even if your swift PR passes, CI in this repo will continue to fail since it's not using a just-built toolchain, and we will no longer be able to build just Foundation at desk |
SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
xedin
force-pushed
the
fix-incorrect-foundation-resources-hardcode
branch
from
0d73517 to
d14ceaf
Compare
|
@swift-ci please test |
…ng#855) SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
…901) SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix. Co-authored-by: Pavel Yaskevich <xedin@apache.org>
…ng#855) SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879. The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host". This means that the hard-coded resources path needs to be updated to include "-tool" suffix.
SwiftPM used to incorrectly build tests for both host and target. That has been fixed by swiftlang/swift-package-manager#7879.
The fix makes sure that if there are any direct macro dependencies in test targets xctest bundle is only built for "host".
This means that the hard-coded resources path needs to be updated to include "-tool" suffix.