[Explicit Module Builds] Use the new batch scanning mode for versioned PCM clang modele re-scan #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test that relies on the versioned PCM re-scanning is currently failing with this change, but the driver side of things looks okay to me. I'm investigating if there is something we are missing in the scanner. |
artemcm
force-pushed
the
BatchVersionedClangScan
branch
2 times, most recently
from
ec78c33 to
a8ac888
Compare
DougGregor
approved these changes
Aug 27, 2020
Sources/SwiftDriver/Explicit Module Builds/ModuleDependencyScanning.swift
Outdated
Show resolved
Hide resolved
nkcsgexi
approved these changes
Aug 27, 2020
…d PCM clang modele re-scan swiftlang/swift#33569 introduced a batch dependency scanning mode to save up on the overhead of clang instance creation. This patch switches `swift-driver` over to using the new batch mode instead of generating individual `-scan-clang-dependencies` jobs for each re-scan.
artemcm
force-pushed
the
BatchVersionedClangScan
branch
from
a8ac888 to
531aee6
Compare
|
@swift-ci please test |
artemcm
added a commit
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftlang/swift#33569 introduced a batch dependency scanning mode to save up on the overhead of clang instance creation.
This patch switches
swift-driverover to using the new batch mode instead of generating individual-scan-clang-dependenciesjobs for each re-scan.