[Dependency Scanner] Batch scanner: extract target triple from the PCMArgs for the batch invocation. #33671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
nkcsgexi
reviewed
Aug 27, 2020
|
@swift-ci please test Windows platform |
artemcm
force-pushed
the
BatchScannerTargetExtract
branch
3 times, most recently
from
e426d12 to
6cff053
Compare
|
@swift-ci please smoke test |
nkcsgexi
reviewed
Aug 28, 2020
…nherit the creating invocation's extra clang args. This ensures that when the dependency scanner is invoked with additional clang (`-Xcc`) options, the Clang scanner is correctly configured using these options.
artemcm
force-pushed
the
BatchScannerTargetExtract
branch
from
6cff053 to
5afbddb
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the created invocation will end up re-using the parent compiler invocation's target triple for every created scanning instance.
I stumbled upon this when testing swiftlang/swift-driver#225.
The PCMArgs we pass in to the batch scanner are intended to be clang arguments and are prefixed with
-Xcc, so they do not affect the created compiler instance.