Skip to content

[XCTestObservation] Replace sharedTestObservationCenter with shared #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2016
Merged

[XCTestObservation] Replace sharedTestObservationCenter with shared #82

merged 1 commit into from
Mar 27, 2016

Conversation

shingt
Copy link
Contributor

@shingt shingt commented Mar 26, 2016

Replaced sharedTestObservationCenter with shared as described in https://bugs.swift.org/browse/SR-1063.

@shingt
Copy link
Contributor Author

shingt commented Mar 26, 2016

Sorry, resolving conflicts.
=> fixed

@modocache
Copy link
Contributor

Excellent, thanks! @mike-ferris-apple, could you ask @swift-ci to please test?

@mike-ferris
Copy link

@swift-ci please test

@modocache modocache mentioned this pull request Mar 27, 2016
Merged
@modocache modocache merged commit 2df27c5 into swiftlang:master Mar 27, 2016
@modocache
Copy link
Contributor

Excellent, thanks @shingt! 💯

(The OS X CI failure is expected. #77 has some additional context.)

@briancroom briancroom mentioned this pull request Apr 4, 2016
Merged
@shingt shingt deleted the replace-shared branch April 4, 2016 05:06
@modocache modocache mannequin mentioned this pull request Mar 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shingt @modocache @mike-ferris