[SR-1063] Have XCTestObservationCenter conform to new Swift 3 naming rules

[modocache]

Previous ID	SR-1063
Radar	None
Original Reporter	@modocache
Type	Bug
Status	Closed
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s	XCTest
Labels	Bug, StarterBug
Assignee	shingt (JIRA)
Priority	Medium

md5: da16a265f7fa73b0cb4ebaf710ed7ada

Issue Description:

swift-corelibs-xctest's XCTestObservationCenter defines a method sharedTestObservationCenter. However, that method in Apple XCTest is now named simply shared.

swift-corelibs-xctest's XCTestObservationCenter should define shared as well, since our goal is to have an identical API. Change the method name and update the tests.

(I wonder if there are other discrepancies brought about by the Swift 3 naming rules? We should investigate.)

[swift-ci]

Comment by Shinichi Goto (JIRA)

> However, that method in Apple XCTest is now named simply shared.

Where can I find this?

[modocache]

1. Download a Swift 3 snapshot from https://swift.org, such as the 3-24 snapshot.

2. Open Xcode. In the preferences pane, select the Swift 3 toolchain as the active toolchain.

3. Create a new iOS app project named "Foo" in Xcode, choosing "Swift" as your language, and checking the box marked "Include unit tests".

4. Your project should include a "FooTests.swift" file. Within that file, type XCTestObservationCenter.sha. Autocompletion should suggest XCTestObservation.shared().

5. Finish typing XCTestObservation.shared(), then navigate to the symbol definition in Xcode by holding down the command key and clicking on shared(). The Swift header generated by the Swift ClangImporter should show func shared() as being defined.

[swift-ci]

Comment by Shinichi Goto (JIRA)

Thanks and sorry for my stupid question. I was looking for only in swift repo and so I couldn't find it.
I made a PR, and will investigate if other differences from Swift 3 rules exist as well.

[modocache]

No stupid questions--thanks for asking, and thanks for the PR!! Comment here if you find anything.

[swift-ci]

Comment by Shinichi Goto (JIRA)

Sure!

[modocache]

Fixed in #82 Thanks, shingt (JIRA User)!

[swift-ci]

Comment by Shinichi Goto (JIRA)

Hi, so I've done investigation on discrepancies and found some in XCTestCase:

//
// expectationWithDescription
//
// swift-corelibs-xctest
public func expectationWithDescription(description: String, file: StaticString = #file, line: UInt = #line) -> XCTestExpectation

// Apple XCTest 
public func expectation(withDescription description: String) -> XCTestExpectation

//
// waitForExpectationsWithTimeout
//
// swift-corelibs-xctest
public func waitForExpectationsWithTimeout(timeout: NSTimeInterval, file: StaticString = #file, line: UInt = #line, handler: XCWaitCompletionHandler?) {

// Apple XCTest 
public func waitForExpectations(withTimeout timeout: NSTimeInterval, handler: XCTest.XCWaitCompletionHandler? = nil)

//
// expectationForNotification
//
// swift-corelibs-xctest
public func expectationForNotification(notificationName: String, object objectToObserve: AnyObject?, handler: XCNotificationExpectationHandler?) -> XCTestExpectation {

// Apple XCTest 
public func expectation(forNotification notificationName: String, object objectToObserve: AnyObject?, handler: XCTest.XCNotificationExpectationHandler? = nil) -> XCTestExpectation

Should I make a PR?

[swift-ci]

Comment by Shinichi Goto (JIRA)

Seems #88 already solved this.