eliminate mach_task_self from linux_stubs#86
Merged
MadCoder merged 1 commit intoswiftlang:masterfrom Jun 18, 2016
Merged
Conversation
Contributor
|
could you try to get rid of pthread_mach_thread_np() in the same patch? because that one is also a MACH-ism and it would fit very well in that change set |
Get rid of mach_error_string, mach_vm_deallocate, and mach_test_self by adding missing #if HAVE_MACH in the last couple places it was missing. Avoid needing pthread_mach_thread_np by replacing uses of the _dispatch_thread_port() macro with _dispatch_tid_self()
dgrove-oss
force-pushed
the
kill_mach_task_self_on_linux
branch
from
692cc0f to
92ff1bf
Compare
Contributor
Author
|
Updated. I'm pretty sure using _dispatch_tid_self in place of dispatch_thread_port is the right fix to avoid the expansion out to pthread_mach_thread_np, but if not let me know and I'll try again. |
Contributor
|
Yup using |
das
pushed a commit
that referenced
this pull request
Aug 11, 2016
eliminate mach_task_self from linux_stubs Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
guard stray usage of mach_task_self with #if HAVE_MACH
and remove mach_test_self() from linux_stubs.