resolve all compiler warnings #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing declarations in linux_stubs.h for 3 functions: pthread_mach_thread_np, mach_error_string and mach_vm_deallocate For empty struct warning from mach_msg_header_t defined in linux_stubs.h, I suppress the warning by add -Wno-extern-c-compat
|
no, this isn't the right way, none of these functions should be called on linux, so the code should be compiled out. #86 is already doing work in that direction, this work is directly conflicting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing declarations in linux_stubs.h for 3 functions:
pthread_mach_thread_np, mach_error_string and mach_vm_deallocate
For empty struct warning from mach_msg_header_t defined in linux_stubs.h,
I suppress the warning by add -Wno-extern-c-compat