-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PropertyListEncoder/Decoder from Darwin SDK Overlay #1849
Conversation
@swift-ci please test |
1 similar comment
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this just works that's great news for our work on bridging, which was the hold-up before. cc @millenomi
<key>CFBundleOtherKey</key> | ||
<string>other...</string> | ||
</dict> | ||
</plist> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case which includes at least 1 of each property list type? Data
and Date
are missing here.
@parkera I have added the Data/Date tests. Can you start the tests, please? |
@swift-ci please test |
1 similar comment
@swift-ci please test |
@parkera @millenomi can we merge this? |
Yup, thanks! |
It's available in the Swift 5.1 branch: swiftlang/swift-corelibs-foundation#1849
* Migrate LinterCache to use Codable models improving performance and type safety * Fix Linux * Avoid creating a Decoder if it won't be used For example if the file doesn't exist or can't be read. * Use corelibs plist coder if available It's available in the Swift 5.1 branch: swiftlang/swift-corelibs-foundation#1849 * Remove unused error case
Can this process binary plist?! It's still crashing on me when I extract an .ipa on Linux :( |
@rafiki270 A cursory look at the code indicates that it should support binary plists, if you could file a bug on https://bugs.swift.org with a reproducible example that would be very helpful and avoid the issue being forgotten about, thanks. |
No description provided.