Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PropertyListEncoder/Decoder from Darwin SDK Overlay #1849

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Added PropertyListEncoder/Decoder from Darwin SDK Overlay #1849

merged 2 commits into from
Jan 31, 2019

Conversation

pvieito
Copy link
Contributor

@pvieito pvieito commented Jan 24, 2019

No description provided.

@pvieito
Copy link
Contributor Author

pvieito commented Jan 25, 2019

@swift-ci please test

1 similar comment
@spevans
Copy link
Contributor

spevans commented Jan 25, 2019

@swift-ci please test

Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this just works that's great news for our work on bridging, which was the hold-up before. cc @millenomi

<key>CFBundleOtherKey</key>
<string>other...</string>
</dict>
</plist>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test case which includes at least 1 of each property list type? Data and Date are missing here.

@pvieito
Copy link
Contributor Author

pvieito commented Jan 29, 2019

@parkera I have added the Data/Date tests. Can you start the tests, please?

@spevans
Copy link
Contributor

spevans commented Jan 29, 2019

@swift-ci please test

1 similar comment
@compnerd
Copy link
Member

@swift-ci please test

@pvieito
Copy link
Contributor Author

pvieito commented Jan 31, 2019

@parkera @millenomi can we merge this?

@parkera parkera merged commit d2d72f8 into swiftlang:master Jan 31, 2019
@parkera
Copy link
Contributor

parkera commented Jan 31, 2019

Yup, thanks!

@pvieito pvieito deleted the property-list-encoder branch April 11, 2019 20:16
@pvieito pvieito restored the property-list-encoder branch April 11, 2019 20:17
jpsim added a commit to realm/SwiftLint that referenced this pull request Jul 6, 2019
jpsim added a commit to realm/SwiftLint that referenced this pull request Jul 7, 2019
* Migrate LinterCache to use Codable models

improving performance and type safety

* Fix Linux

* Avoid creating a Decoder if it won't be used

For example if the file doesn't exist or can't be read.

* Use corelibs plist coder if available

It's available in the Swift 5.1 branch: swiftlang/swift-corelibs-foundation#1849

* Remove unused error case
@rafiki270
Copy link

Can this process binary plist?! It's still crashing on me when I extract an .ipa on Linux :(

@spevans
Copy link
Contributor

spevans commented Jun 5, 2020

@rafiki270 A cursory look at the code indicates that it should support binary plists, if you could file a bug on https://bugs.swift.org with a reproducible example that would be very helpful and avoid the issue being forgotten about, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants