-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate LinterCache to use Codable models #2799
Merged
Merged
+73
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improving performance and type safety
For example if the file doesn't exist or can't be read.
It's available in the Swift 5.1 branch: swiftlang/swift-corelibs-foundation#1849
Generated by 🚫 Danger |
marcelofabri
reviewed
Jul 7, 2019
@@ -1,12 +1,33 @@ | |||
import Foundation | |||
|
|||
internal enum LinterCacheError: Error { | |||
private enum LinterCacheError: Error { | |||
case invalidFormat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to be unused now
marcelofabri
approved these changes
Jul 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving performance and type safety. This changes the cache file format from JSON to binary plist when available, which also happens to reduce disk usage by around ~10% in my tests.
For a project with about 7k Swift files amounting to about ~500k lines of Swift code, here are the benchmarks for before and after: