[build-script-helper] Switch the --no-clean flag to --clean and have it actually do something
#1558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artemcm, maybe you can review if Alex is busy or off this week? |
…ave it actually do something Instead, swiftlang/swift#75053 makes sure `build-script` doesn't pass in the flag by default, so you can explicitly invoke it only when needed.
finagolfin
added a commit
to finagolfin/swift
that referenced
this pull request
Jul 19, 2024
… the flag do nothing Rather than make this change, swiftlang/sourcekit-lsp@37d003eb7 had the `--no-clean` flag do nothing, which means the flag can't be used at all. Instead, switch the flag to `--clean` in swiftlang/sourcekit-lsp#1558 and don't invoke it by default.
finagolfin
changed the title
--no-clean flag actually do something, ie clean by default--no-clean flag to --clean and have it actually do something
ahoppen
approved these changes
Jul 22, 2024
|
@swift-ci Please test |
|
I think you'll need to run the CI here on the two pulls together, since we're changing the flag and the unmodified |
|
Yep, linux CI fails with Both pulls need to be tested together here, but not there. Also, swiftlang/swift#75053 will need to be merged first. |
|
I’ll just merge swiftlang/swift#75053 first and then this one. |
|
@swift-ci Please test |
|
Thanks, Alex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, swiftlang/swift#75053 makes sure
build-scriptdoesn't pass in the flag bydefault, so you can explicitly invoke it only when needed.
This simply reverts 37d003e and renames the flag, so the flag can be invoked when needed and the build will be cleaned again.