Support custom build commands for Swift static Linux/Wasm SDK builds#149
Conversation
shahmishal
left a comment
There was a problem hiding this comment.
Looks good, make sure to review the forked repo path once test is completed.
- Revert the script back to swiftlang/github-workflows url
a793871 to
0aeabcc
Compare
|
Reverted the script URL back to |
|
Update: Removed the description changes that would conflict from this PR. |
|
I'm going to squash commits and re-test to make the PR branch testing dance clearer |
2cca7da to
f956c65
Compare
This reverts commit f956c65.
|
Previous commit using this branch for the script URL is green. I've now reverted the script URL back to @shahmishal I think this is ready to merge if it looks good to you, thanks! |
|
Thanks for landing this so quickly! |
Enable alias expansion and run
alias swift="$SWIFT_EXECUTABLE_FOR_(NAME)_SDK"before performing the build so that we can support customswift buildcommands while still using the correct executable.I'll add a commit that points to the script URL on my branch for testing this PR, then remove it before merging.
Resolves #147