Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html/parser): potential bug in spec #5779

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

alexander-akait
Copy link
Contributor

@alexander-akait alexander-akait commented Sep 7, 2022

Description:

I found a bug in HTML spec, so I started to fix it in spec and our parser + tests for html5tests-lib for other parser

Original issue - whatwg/html#7922

So we are showring potential fix in spec/parser here (and no problems with other tests). Let's merge when HTML spec marked it as bug and fix it in spec.

BREAKING CHANGE:

No

Related issue (if exists):

Ref: whatwg/html#7922
Ref: html5lib/html5lib-tests#150

@alexander-akait alexander-akait marked this pull request as ready for review September 15, 2022 21:13
@alexander-akait
Copy link
Contributor Author

alexander-akait commented Sep 15, 2022

@kdy1 Ready to merge, the bug was fixed in spec (links and more infromation above)

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_html_parser

@kdy1 kdy1 enabled auto-merge (squash) September 16, 2022 02:46
@kdy1 kdy1 added this to the Planned milestone Sep 16, 2022
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 57e9f9c into swc-project:main Sep 16, 2022
@alexander-akait alexander-akait deleted the fix-potential-bug-in-spec branch September 16, 2022 04:21
@kdy1 kdy1 modified the milestones: Planned, v1.3.2 Sep 19, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants