Table parts in <template>- <td> and <td>

[alexander-akait]

I have a question about table parts in <template> tag.

I have HTML:

<template id="productrow">
  <tr>
    <td class="record"></td>
    <td></td>
  </tr>
</template>

Ref: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-intable (it is a basic example in docs and it is confusing )

According spec we have an error here, because \n after </tr> goes in:

Anything else
Parse error. Enable foster parenting, process the token using the rules for the "in body" insertion mode, and then disable foster parenting.

Not in first, because current node is <template>:

A character token, if the current node is table, tbody, tfoot, thead, or tr element

That is, any part of the table in the <template> is a parse error?

[annevk]

Thanks for reporting. This looks like an oversight.

cc @whatwg/html-parser

[zcorpan]

Would the spec do the right thing if we check if the current node is template in

A character token, if the current node is table, tbody, tfoot, thead, or tr element

?

There should still be a parse error for

<template id="productrow">
  <tr>
    <td class="record"></td>
    <td></td>
  </tr>
  text here
</template>

[alexander-akait]

@zcorpan I am implementing parser here https://github.com/swc-project/swc/tree/main/crates/swc_html_parser using spec and tried to add template in

A character token, if the current node is table, tbody, tfoot, thead, or tr element

And all works fine, we have html5lib_tests and wpt tests and nothing was broken

Therefore, I thought that perhaps this is a mistake/inaccuracy

[zcorpan]

OK, good to know that it works as intended in your implementation.

It looks like there are no tests currently that exercise this case in html5lib-tests, as far as I can tell. Do you want to contribute new tests?

[alexander-akait]

Yes, there are no tests in html5lib-tests, yes I can send them, should we have #errors for this. I would like to just understand whether we should go for the first point or maybe we should not create parser error when it is in template in anything else?

[zcorpan]

Yes the test should use #errors.

IMO, the new tests can be written to assume the fix in #7922 (comment) (so no error for whitespace, error for other text). I can submit a PR for the spec sometime this week, unless someone beats me to it. :)

Thanks!

[alexander-akait]

@zcorpan Hello, sorry for big delay, I sent tests #7922, also I pushed the fix in our parser (so you can see all tests passed + we use tests from html5lib-tests) swc-project/swc#5779

[zcorpan]

Thanks! Spec PR: #8271

[alexander-akait]

@zcorpan Big thank you

[zcorpan]

Thank you!