Add a way to pass custom ENV variables. #1134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swashata
requested changes
Oct 29, 2020
Owner
swashata
left a comment
swashata
left a comment
There was a problem hiding this comment.
Kindly make these changes. I think, in the client side code, we should use something like console.log(process.env.WPACKIO_ENV). That's how CRA does it.
| this.customEnv = {}; | ||
| Object.keys(process?.env || {}).forEach(key => { | ||
| if (key.startsWith('WPACKIO_')) { | ||
| this.customEnv[key] = JSON.stringify(process?.env?.[key]); |
Owner
There was a problem hiding this comment.
Correct me if I am wrong, but shouldn't this be
this.customEnv[`process.env.${key}`] = JSON.stringify(process?.env?.[key]);|
|
||
| // check in class | ||
| // @ts-ignore (since this is private). Check it's set. | ||
| expect(JSON.parse(cwc.customEnv.WPACKIO_ENV)).toBe('test'); |
Owner
There was a problem hiding this comment.
Once we change the key of customEnv, we need to update here too
expect(JSON.parse(cwc.customEnv['process.env.WPACKIO_ENV'])).toBe('test');
Author
|
Sorry for the delay on this. I ended up breaking my wrist and getting surgery, so typing is a pain. Hopefully I should be able to contribute in a few weks. |
Owner
|
No worries at all. Take rest and get well soon 🙂 |
swashata
added a commit
that referenced
this pull request
Apr 26, 2021
swashata
added a commit
that referenced
this pull request
Apr 26, 2021
Owner
|
This isn't needed anymore, since v6 has the functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the user pass custom ENV variables to webpack's Define plugin. The variable must start with
WPACKIO_to be included to prevent leaking sensitive env variables client-side. 😁