Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include SrcLoc info with variable binding sites #993

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Include SrcLoc info with variable binding sites #993

merged 2 commits into from
Jan 10, 2023

Conversation

byorgey
Copy link
Member

@byorgey byorgey commented Jan 10, 2023

Towards #863 / helping with #983.

@byorgey byorgey requested a review from kostmo January 10, 2023 02:21
@restyled-io restyled-io bot mentioned this pull request Jan 10, 2023
Merged
@restyled-io @restyled-commits
Restyled by fourmolu (#994)
ac5f556 
Co-authored-by: Restyled.io <commits@restyled.io>
kostmo
kostmo approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@kostmo kostmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byorgey byorgey added the merge me Trigger the merge process of the Pull request. label Jan 10, 2023
@mergify mergify bot merged commit 1839c72 into main Jan 10, 2023
@mergify mergify bot deleted the feature/locvar branch January 10, 2023 02:44
@xsebek xsebek mentioned this pull request Jan 25, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 25, 2023
@xsebek
Improve OnHover for Def/Let, App and Const (#986)
652ba55 
* unfold function application and tuples
* add type signatures to syntax using #990 
* show hovered variable definition name using #993
* fix indenting for multiline text

- closes #985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostmo kostmo kostmo approved these changes

Assignees
No one assigned
Labels
merge me Trigger the merge process of the Pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byorgey @kostmo