Skip to content

Add lookaside to traverse - Limits DFS revisit #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Add lookaside to traverse - Limits DFS revisit #1190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e1b78
Add lookaside to traverse
dballance Nov 29, 2017
87f30b3
Fix indentation
dballance Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/specmap/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ class SpecMap {
// We might consider making this (traversing & application) configurable later.
function createKeyBasedPlugin(pluginObj) {
return function* (patches, specmap) {
const traversedRefs = {}

for (const patch of patches.filter(lib.isAdditiveMutation)) {
yield* traverse(patch.value, patch.path, patch)
}
Expand All @@ -102,9 +104,21 @@ class SpecMap {
for (const key of Object.keys(obj)) {
const val = obj[key]
const updatedPath = path.concat(key)

if (lib.isObject(val)) {
yield* traverse(val, updatedPath, patch)
const isObj = lib.isObject(val)

// If the object has a meta '$$ref' - and store this $$ref
// in a lookaside to prevent future traversals of this $ref's tree.
const objRef = obj.$$ref
const traversed = specmap.allowMetaPatches && traversedRefs[obj.$$ref]

if (!traversed) {
if (isObj) {
// Only store the ref if it exists
if (specmap.allowMetaPatches && objRef) {
traversedRefs[objRef] = true
}
yield* traverse(val, updatedPath, patch)
}
}

if (!isRootProperties && key === pluginObj.key) {
Expand Down