Add lookaside to traverse - Limits DFS revisit
#1190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #1150. Adds a 'per-patch' lookaside to the
traversemethod withincreateKeyBasedPlugin.Motivation and Context
Previously, a
$refwould be traversed multiple times during spec resolution. This change allows$refs to be resolved once and prevents future unnecessary revisits.Fixes #1150 - but still some questions about handling
allOfresolution that may be handled in another PR.How Has This Been Tested?
All tests appear to pass - unsure if additional tests are required or need to be added for this change.
Existing code. Small spec (~5k lines formatted JSON). Average Resolution of ~1100ms.

With change. Average Resolution of ~250ms.

Existing code. Large spec (~141k lines formatted JSON). NOTE:
allOfplugin disabled for the below tests - only running$refplugin.???? I couldn't actually get this to complete in any reasonable time. 😄
With change. Average Resolution of ~5200ms.

Types of changes
package.json)Checklist: