-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP] Run unit tests on 'tests' directory #7675
[PHP] Run unit tests on 'tests' directory #7675
Conversation
https://travis-ci.org/swagger-api/swagger-codegen/builds/342288933#L5767 🤔 💦
|
@ackintosh no worry. I'll take a look later this week. |
@@ -46,7 +46,7 @@ | |||
<goal>exec</goal> | |||
</goals> | |||
<configuration> | |||
<executable>vendor/bin/phpunit</executable> | |||
<executable>vendor/bin/phpunit tests</executable> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to do something like the following instead:
<configuration>
<executable>vendor/bin/phpunit</executable>
<arguments>
<argument>tests</argument>
</arguments>
</configuration>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😭 ✨
swagger-codegen/samples/client/petstore/php/SwaggerClient-php/tests/PetApiTest.php Lines 381 to 385 in 47614bb
hmm... |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
By #7200, the
test
directory is completely cleaned and all the test code is integrated intotests
. So we have to run unit tests which in thetests
directory.