Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] "test" should not contain real codes. #7200

Closed
ackintosh opened this issue Dec 18, 2017 · 0 comments
Closed

[PHP] "test" should not contain real codes. #7200

ackintosh opened this issue Dec 18, 2017 · 0 comments
Labels
Client: PHP Enhancement: CI/Test
Milestone
v2.4.0

Comments

@ackintosh
Copy link
Contributor

ackintosh commented Dec 18, 2017 •
edited
Loading

Description

"test" should contain only auto-generated test codes and the unit tests which tests auto-generated codes should be in "tests".

e.g. test/Api/PetApiTest.php contains hand-written codes. 😕

python is very clean. ✨
__

Swagger-codegen version

2.3.0

Suggest a fix/enhancement
  • Move the real codes to "tests"
  • Clean up "test" ( rm -rf test && bin/php-petstore.sh )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Client: PHP Enhancement: CI/Test
Projects
None yet
Milestone
v2.4.0
Development

No branches or pull requests
2 participants
@wing328 @ackintosh