Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Cleanup EnumTest #7282

Merged
merged 2 commits into from
Jan 7, 2018
Merged

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Dec 31, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

refs #7200

"test" should not contain real codes.

This PR moves hand-written test codes to "tests" and cleanup "test/Model/Enum(Class|Test)Test.php".

@ackintosh
Copy link
Contributor Author

@wing328 wing328 added this to the v2.4.0 milestone Jan 7, 2018
@wing328 wing328 changed the base branch from master to 2.4.0 January 7, 2018 03:42
@wing328 wing328 merged commit 50d2178 into swagger-api:2.4.0 Jan 7, 2018
@ackintosh ackintosh deleted the cleanup-enum-test branch January 7, 2018 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants