Adds log file test fix and extends blacklist to allows for single files #79
Conversation
html5validator/cli.py
Outdated
| args = parse_yaml(args.config, args) | ||
| LOGGER.debug(args) | ||
| args, extra_args = parse_yaml(args.config, args) | ||
| LOGGER.debug(args, extra_args) |
There was a problem hiding this comment.
Don't you need a format string as the first argument?
At this point, logging is also not configured yet. Maybe remove.
There was a problem hiding this comment.
I removed the logging here. Don't know what you refer to with format string and the first argument in the path to the config file.
| @@ -90,8 +93,8 @@ def main(): | |||
| args, extra_args = parser.parse_known_args() | |||
|
|
|||
| if args.config is not None: | |||
| args = parse_yaml(args.config, args) | |||
| LOGGER.debug(args) | |||
| args, extra_args = parse_yaml(args.config, args) | |||
There was a problem hiding this comment.
I didn't realize this before, but overwriting all command line arguments is really not great. A config file should serve as a default that can be overridden by command line args. A todo item for later.
There was a problem hiding this comment.
The issue with this is that most command-line arguments have a default so we would need to have a list of what the default arguments are to compare to what was passed.
|
Thanks! |
Much cleaner of #75