Fixes test with log file and adds skip option #75

Cyb3r-Jak3 · 2020-10-01T02:19:29Z

Biggest Changes

Fixes the test with log file and separate normal test from config test
Adds Skip file option. Similar to the blacklist option.

Cyb3r-Jak3 · 2020-10-02T01:14:17Z

~~Pypy implementation in Github Actions does not appear to be working. See actions/runner-images#1716~~
Resolved

… be a seperate PR

Cyb3r-Jak3 · 2020-10-03T12:52:13Z

@svenkreiss Would you be open to switching to GitHub Actions for the CI?

I have been messing around with it a bit and if switching there is a lot more tests that can be run such as different os and java versions. Here is an example of what it would look like: https://github.com/Cyb3r-Jak3/html5validator/actions/runs/285811420.
That is testing the same python versions, with java 8-13 and ubuntu 16, 18, and 20, mac-os and windows. Allows for seeing if there are issues with different java version or OS.

- Adds the ability to skip specific files. - Adds tests for skip - Moves tests to a separate directory to decrease download size.

Cyb3r-Jak3 · 2020-11-28T19:57:52Z

@svenkreiss I added a new option --skip to allow users to skip certain files. This was requested in the GitHub action. Cyb3r-Jak3/html5validator-action#12.

Was not sure if you want a separate PR for it.

khusika · 2021-03-24T18:43:39Z

Is there any plan to merge this?

svenkreiss · 2021-03-25T05:38:14Z

Thanks @Cyb3r-Jak3 for the PR and @khusika for the reminder.

The moved tests are a blocker for me. I want to be able to run these tests without the full source tree.

I am also against a new command line argument but it does make a lot of sense to extend --blacklist to also remove individual files and not only directories.

Cyb3r-Jak3 · 2021-03-26T02:43:43Z

@svenkreiss
Tests are back to where they were. Also, make it so the blacklist command does files and directories.

You are definitely going to want squash merge this as the config tests don't work on Windows due to the path.

svenkreiss

Thanks for fixing those.

The diff is still huge and it is not clear to me why. Can you revert so that the diff becomes readable?

I have added some further requests to revert changes that I think were from your previous changes and are now unnecessary. Maybe I am wrong about some of them, so please reply with a short comment why those are necessary now. Thanks!

svenkreiss · 2021-03-26T06:32:07Z

setup.py

@@ -18,14 +18,13 @@
 setup(
    name='html5validator',
    version=__version__,
-    packages=['html5validator', 'html5validator.tests', 'vnujar'],


svenkreiss · 2021-03-26T06:32:13Z

setup.py

    license='MIT',
    description='Validate HTML5 files.',
    long_description=open('README.rst').read(),
    author='Sven Kreiss',
    author_email='me@svenkreiss.com',
    url='https://github.com/svenkreiss/html5validator',
-


svenkreiss · 2021-03-26T06:32:21Z

html5validator/validator.py


        if skip_invisible:
            # filter out directory names starting with '.'
-            invisible_dirs = [d for d in dirnames if d[0] == '.']


svenkreiss · 2021-03-26T06:33:19Z

html5validator/tests/test_config.py

@@ -1,173 +1,187 @@
-# -*- coding: utf-8 -*-


Why is this entire file different?

Same for all the files in tests/config_files?

svenkreiss · 2021-03-26T06:33:48Z

MANIFEST.in

@@ -1,3 +1,2 @@
 include README.rst LICENSE vnujar/vnu.jar
-recursive-include tests *
-recursive-exclude tests *.pyc .DS_Store
+prune html5validator/tests


Cyb3r-Jak3 · 2021-03-27T00:26:16Z

Looking through everything, I agree this got incredibly messy. I am going to close out this PR and start fresh.

Cyb3r-Jak3 added 16 commits September 29, 2020 23:22

Added extra args to config file. Better removal of test files

cc0ad41

Seeing if matrix improves speed

6c17031

Trying with Github workflows to see if they are quicker

334e715

Changed java version

1fb8f81

Adding pip and tests to install

669c149

Removing pypy because github does not support it

9990282

Added different OSs and working on pypy3

2ed960f

Fixed yaml issue

e5939ec

Dropped pypy3 from github as it does not appear supported

0c18ad6

Split up the os tests into seperate jobs and made java matrix

1f07ea8

Removed other python from travis as not needed

11fc6e0

Working on java matrix

56a54d2

Removed even more from the matrix for java

7de11c6

Made everything much simpler

d678e73

Updated setup.py and added wheel for quicker install

c837cea

Adds in caching

21eebac

Switched back to .travis-ci.yml as migration to GitHub Actions should…

86973ed

… be a seperate PR

Cyb3r-Jak3 changed the title ~~Fixes test with log file and adds Github Action testing~~ Fixes test with log file Oct 3, 2020

Adds skip file option (#1)

c24c749

- Adds the ability to skip specific files. - Adds tests for skip - Moves tests to a separate directory to decrease download size.

Cyb3r-Jak3 changed the title ~~Fixes test with log file~~ Fixes test with log file and adds skip option Nov 28, 2020

Cyb3r-Jak3 mentioned this pull request Nov 28, 2020

How can I ignore a single file? Cyb3r-Jak3/html5validator-action#12

Closed

Cyb3r-Jak3 added 4 commits March 24, 2021 22:51

Move tests back

c3c2051

Renamed test files

08b26fa

Changes skip to blacklist

b8360fd

Think I did it??

1c86501

Cyb3r-Jak3 added 2 commits March 25, 2021 19:28

Fix ignore

ecc2ac6

Refix and issue that was missed with merge

f6e5e87

Merge branch 'master' into master

0996040

svenkreiss reviewed Mar 26, 2021

View reviewed changes

Cyb3r-Jak3 closed this Mar 27, 2021

Cyb3r-Jak3 mentioned this pull request Mar 27, 2021

Adds log file test fix and extends blacklist to allows for single files #79

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixes test with log file and adds skip option #75

Fixes test with log file and adds skip option #75

Uh oh!

Cyb3r-Jak3 commented Oct 1, 2020 •

edited

Loading

Uh oh!

Cyb3r-Jak3 commented Oct 2, 2020 •

edited

Loading

Uh oh!

Cyb3r-Jak3 commented Oct 3, 2020

Uh oh!

Cyb3r-Jak3 commented Nov 28, 2020

Uh oh!

khusika commented Mar 24, 2021

Uh oh!

svenkreiss commented Mar 25, 2021

Uh oh!

Cyb3r-Jak3 commented Mar 26, 2021

Uh oh!

svenkreiss left a comment

Uh oh!

svenkreiss Mar 26, 2021

Uh oh!

svenkreiss Mar 26, 2021

Uh oh!

svenkreiss Mar 26, 2021

Uh oh!

svenkreiss Mar 26, 2021

Uh oh!

svenkreiss Mar 26, 2021

Uh oh!

Cyb3r-Jak3 commented Mar 27, 2021

Uh oh!

Uh oh!

Fixes test with log file and adds skip option #75

Fixes test with log file and adds skip option #75

Uh oh!

Conversation

Cyb3r-Jak3 commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Biggest Changes

Uh oh!

Cyb3r-Jak3 commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cyb3r-Jak3 commented Oct 3, 2020

Uh oh!

Cyb3r-Jak3 commented Nov 28, 2020

Uh oh!

khusika commented Mar 24, 2021

Uh oh!

svenkreiss commented Mar 25, 2021

Uh oh!

Cyb3r-Jak3 commented Mar 26, 2021

Uh oh!

svenkreiss left a comment

Choose a reason for hiding this comment

Uh oh!

svenkreiss Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

svenkreiss Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

svenkreiss Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

svenkreiss Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

svenkreiss Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

Cyb3r-Jak3 commented Mar 27, 2021

Uh oh!

Uh oh!

Cyb3r-Jak3 commented Oct 1, 2020 •

edited

Loading

Cyb3r-Jak3 commented Oct 2, 2020 •

edited

Loading