fix: disable hmr when explicitly disabled in vite config #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one caveat is for testsuites that actually do test hmr behavior with vitest, you have to explicitly set compilerOptions.hmr = true. these suites are almost guaranteed to be our own or those of other tooling devs very close to us. Users would almost never make custom hmr things that need testing this way. |
bluwy
approved these changes
May 24, 2024
dominikg
changed the title
|
caveat mentioned previously no longer applies. vitest sets server.hmr to false so we don't have to do anything. |
Merged
dominikg
added a commit
that referenced
this pull request
May 25, 2024
* feat: disable hmr when running in vitest by default * refactor: use vite server.hmr config instead that is set by vitest * fix: enforce hmr false, update changeset (cherry picked from commit f7409c8)
dominikg
added a commit
that referenced
this pull request
May 29, 2024
* fix: disable hmr when explicitly disabled in vite config (#913) * feat: disable hmr when running in vitest by default * refactor: use vite server.hmr config instead that is set by vitest * fix: enforce hmr false, update changeset (cherry picked from commit f7409c8) * fix: ensure vite config is only resolved once in lazy init of vitePreprocess (#912) * fix: ensure vite config is only resolved once * fix: add back inlined function to please ts (cherry picked from commit 1211f97) * fix: remove extraneous checks for viteConfig.server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improvement coming from discussion in #909