chore: backport fixes #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: disable hmr when running in vitest by default * refactor: use vite server.hmr config instead that is set by vitest * fix: enforce hmr false, update changeset (cherry picked from commit f7409c8)
|
had to refactor the hmr one slightly due to the changes in v4 in the options, but spirit is identical |
bluwy
approved these changes
May 27, 2024
| const hot = | ||
| !viteConfig.isProduction && | ||
| !preResolveOptions.isBuild && | ||
| viteConfig.server && |
There was a problem hiding this comment.
Something I just noticed but not a big deal to change. It looks like viteConfig.server is always truthy, but this line implies otherwise, which could be confusing because we don't want to disable HMR if the server is not configured (HMR would've been enabled by default in dev)
| */ | ||
| function enforceOptionsForHmr(options) { | ||
| function enforceOptionsForHmr(options, viteConfig) { | ||
| if (options.hot && viteConfig.server?.hmr === false) { |
Merged
This was referenced Sep 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these 2 patches are good to have in v3 too