Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix separate bind:group with one array #4774

Closed
wants to merge 5 commits into from

Conversation

Th0rN13
Copy link
Contributor

@Th0rN13 Th0rN13 commented May 4, 2020

Fix #4397

This is two issues:

  • push to array add duplicated values, i use Set
  • unchecked values need to compare to previous values, so need store old values for each group, i use Map

Add two tests:

  • one check what check\uncheck work with binded array
  • another: identical values in other group does not affect the first

@pushkine
Copy link
Contributor

pushkine commented May 4, 2020

you're introducing a memory leak with the map of array to sets

@Th0rN13 Th0rN13 marked this pull request as draft May 4, 2020 12:51
@Conduitry
Copy link
Member

Closing in favor of #4877.

@Conduitry Conduitry closed this Jun 8, 2020
@Th0rN13 Th0rN13 deleted the fix/gh-4397 branch June 9, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkbox bind:group doesn't play nice with duplicated values
3 participants