Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bind:group with duplicated values #4877

Conversation

tanhauhau
Copy link
Member

Fixes #4397

  • using set to prevent duplicate
  • passing in the changed input .__value and checked to determine whether to add or remove the current value, to not to be affected by its duplicate.

side note: this seemed adding more code to fix an edge case, i was wondering should we have flags for certain bugfixes, so user can opt-in more code for fixing things, while majority can stay slim.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests tests with npm test or yarn test)

@Conduitry Conduitry merged commit 787ece6 into sveltejs:master Jun 8, 2020
@tanhauhau tanhauhau deleted the tanhauhau/fixed-bind-group-with-duplicated-values branch June 9, 2020 00:37
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkbox bind:group doesn't play nice with duplicated values
2 participants