-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate svelte:component
#12694
feat: deprecate svelte:component
#12694
Conversation
🦋 Changeset detectedLatest commit: 63968ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svelte:component
and warn for lowercase object.component
rendering
The more I think about this, the more I think we should just treat The only sticking point that I'm aware of is Svelte Native, which has something called property elements. @halfnelson would this change be a dealbreaker? |
I mean technically you could have a
How are they dealing with it? If it's a preprocessor thing wouldn't that be invisible to svelte? |
I have no idea, but it doesn't look like it's preprocessing (there is a Svelte Native preprocessor, but it only replaces |
I dug a bit: at least from what i could understand they are shimming the dom api and they are swapping But if i'm not mistaken thet will need to rewrite this part already right? |
Given that we no longer call |
If they plan to "override" clone node treating <comp.onent> as a component would still break them but let's wait to hear from them what they plan to do to support svelte 5 |
@Rich-Harris should we split the |
Yeah, that's probably the right move |
Ok gonna do it quickly and gonna open a new one where we can discuss |
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
35ad00d
to
ffdbb60
Compare
svelte:component
and warn for lowercase object.component
renderingsvelte:component
@Rich-Harris should be good to go now, gonna open the second pr with the other code |
FYI after bumping to 219 I'm getting also FYI - the Svelte 5 docs page still references using svelte:component higher up when talking about components being dynamic. |
That's because sveltekit is using it...we should probably ignore it there |
Svelte 5 rewrite
Close #12668
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint