Skip to content

feat: warn for lowercase object.component rendering #12752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

feat: warn for lowercase object.component rendering #12752

wants to merge 1 commit into from

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

As discussed in #12694 i've reverted the warn for lowercase object.component in that pr and i'm opening this one to continue discussing what we should do.

The options are:

  1. warn like this pr is doing
  2. consider object.component a component and not a RegularElement...this could be technically problematic for Svelte Native so we are waiting for a word from @halfnelson on it (you can follow the discussion starting from here

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: 01165a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

merged #12798, so I'll close this — thanks

@paoloricciuti
Copy link
Member Author

merged #12798, so I'll close this — thanks

Sure, much better honestly...did we also got an answer from Svelte Native side?

@Rich-Harris
Copy link
Member

no, but I'm confident that it's solvable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants