Skip to content

bundle kit renderer alongside app - #3144

Merged
Rich-Harris merged 3 commits into
masterfrom
bundle-kit
Dec 30, 2021
Merged

Rich-Harris merged 3 commits into
masterfrom
bundle-kit

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

The solution to #3137 is pleasingly straightforward — the respond function needs to be bundled and put in the assets directory just like client-side dependencies. Vite does the rest.

I did find myself cringing a bit at the .svelte-kit folder structure, might try and tidy it up a bit.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot

changeset-bot Bot commented Dec 30, 2021 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: be35934

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris linked an issue Dec 30, 2021 that may be closed by this pull request

This branch had an error being deployed

1 failed deployment
Preview — be359348 Deployed Dec 30, 2021 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adapter-node output relies (again) on Kit as a prod dependency

1 participant