Skip to content

docs: clarify how to inline assets #13294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

eltigerchino
Copy link
Member

closes #13285

This PR clarifies that the kit.config.output.bundleStrategy option only affects JS and CSS files while also including an example of how to inline assets through Vite's config.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@eltigerchino eltigerchino added the documentation Improvements or additions to documentation label Jan 9, 2025
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: a622c24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13294-svelte.vercel.app/

this is an automated message

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github merged commit 58eb46a into main Jan 9, 2025
14 checks passed
@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github deleted the docs-inline-assets branch January 9, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-static with bundleStrategy: 'inline' does not inline assets linked via the %sveltekit.assets% alias
3 participants