adapter-static with `bundleStrategy: 'inline'` does not inline assets linked via the `%sveltekit.assets%` alias

[kran6a]

Describe the bug

When using adapter-static along with bundleStrategy: 'inline' assets referenced via %sveltekit.assets%/favicon.png are not base64-encoded and inlined.

Since bundleStrategy: inline is meant to build a whole site/web app into a single .html file, I would expect it to inline asset references.

Reproduction

Run npm run build and open build/app.html to see <link rel="icon" href="./favicon.png" />

https://stackblitz.com/edit/sveltejs-kit-template-default-nsyxgyko?file=src%2Froutes%2Fabout%2F%2Bpage.js

Logs

No response

System Info

Does not matter

Severity

annoyance

Additional Information

No response

[eltigerchino]

I think the bundle strategy options only affect bundling of JavaScript and CSS. As per the docs:

If 'inline', inlines all JavaScript and CSS of the entire app into the HTML. The result is usable without a server (i.e. you can just open the file in your browser).

https://svelte.dev/docs/kit/configuration#output

If you want to inline all of your assets, you'll need to import your assets through Vite and set the assets inline limit to Infinity.

https://vite.dev/config/build-options.html#build-assetsinlinelimit

For example:
src/routes/+layout.svelte

<script>
  // import asset through Vite
  import favicon from './favicon.png';
</script>

<svelte:head>
  <!-- this will be inlined by Vite if it is under the assets inline limit amount -->
  <link rel="icon" href={favicon} />
</svelte:head>

cc: @Rich-Harris is it worth clarifying this in the docs?

[dummdidumm]

Definetly worth clarifying IMO (along with the workaround you mentioned)