Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved the isTerminated semantics to be based on the ActorCell instead of the Mailbox #31

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix: Improved the isTerminated semantics to be based on the ActorCell instead of the Mailbox #31

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c198a1
fix: Fixed the semantics of the Deadletter mailbox as technically it …
Nov 5, 2024
bdc6999
fix: Added back the overriden test
Nov 5, 2024
37e72e7
fix: Flipped the order of the waitForIdle arguments to maintain backw…
Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: Flipped the order of the waitForIdle arguments to maintain backw… 
…ards compatability
  • Loading branch information
Massimo Saliba committed Nov 13, 2024
commit 37e72e7aa90c9b58fedb906f1ca9574bd10e3671
6 changes: 3 additions & 3 deletions src/main/scala/com/suprnation/typelevel/actors/syntax/ActorSystemDebugSyntax.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ trait ActorSystemDebugSyntax {
actorSystem: ActorSystem[F]
) {
def waitForIdle(
checkSchedulerIdle: Boolean = true,
maxTimeout: Duration = 30 second
maxTimeout: Duration = 30 second,
checkSchedulerIdle: Boolean = true
): F[List[NoSendActorRef[F]]] =
Concurrent[F]
.race(
Expand All @@ -51,7 +51,7 @@ trait ActorSystemDebugSyntax {
.pure[F]
.ifM(
Temporal[F].unit,
waitForIdle(checkSchedulerIdle, maxTimeout).void
waitForIdle(maxTimeout, checkSchedulerIdle).void
)
_ <- deadLetters.waitForIdle
_ <- actorSystem.isTerminated.ifM(
Expand Down
Loading