fix: Improved the isTerminated semantics to be based on the ActorCell instead of the Mailbox #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 5, 2024 12:07
…is never closed. Moved the isTermination to the ActorCell and added a terminated state. Added tests for within in the TestKitSpec.
…ards compatability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this previous PR, I modified the
DeadLetterMailbox.isClosedmethod to always returntrueinstead offalseto align with howDispatcher.isTerminatedchecked the mailbox status to determine an actor's liveliness. However, semantically, this was incorrect because a dead-letter mailbox should never be considered closed.This PR reverts that change and relocates the
isTerminatedmethod fromDispatchertoActorCell. The new logic forisTerminatednow correctly checks if the actor has been successfully terminated.Additionally, I have included tests for the
TestKitSpec.withinmethod.