-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-core] Use serialize-error
#983
Conversation
📦 PR PackagesInstall this PR (you need to setup Github packages): yarn add @superfluid-finance/js-sdk@PR983
yarn add @superfluid-finance/ethereum-contracts@PR983
yarn add @superfluid-finance/sdk-core@PR983
yarn add @superfluid-finance/sdk-redux@PR983
yarn add @superfluid-finance/hardhat-deployer@PR983
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - LGTM
XKCD Comic RelifLink: https://xkcd.com/983 |
* Use serialize-error * Downgrade serialize-error
* [SDK-core] Use `serialize-error` (#983) * Use serialize-error * Downgrade serialize-error * fix handler.publish-release-packages (#985) Co-authored-by: Miao ZhiCheng <miao@superfluid.finance> * Add missing stringify (#988) * create operation from framework (#984) * create operation from framework * Export Operation & OperationType Co-authored-by: Miao ZhiCheng <miao@superfluid.finance> Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance> * Test Framework Created Operation + Remove isNativeAssetSuperToken from query (#989) Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance> Co-authored-by: Miao ZhiCheng <miao@superfluid.finance>
* Use serialize-error * Downgrade serialize-error
* Subgraph data integrity validation (#661) * Update dependencies (#930) * Disable public shaming during weekends and some more data to slack bot (#947) * Minor command update (#948) * ci.feature + ci.canary cleanup (#949) * [SDK-redux] Update example project references and add back WalletConnect (#942) * Create Hardhat Deployer (#950) * Update ci.canary.yml (#952) * Resolver Set + Workflow Modifications (#951) * add SetEvent to getAllEvents query (#953) * Subgraph 1.4.4 Release Bump | SDK-Core 0.4.5 Release Bump (#955) * Initialize logic contracts on deployment (using "castrate") (#841) * [SDK-core] Compile AJV validations (#954) * SDK-Core Build Fix (#963) * [EXAMPLES] Fix sdk initializations (#946) * bump sdk-core version to 0.5.0 (#964) * isNativeAssetSuperToken added to Token entity (#968) * Adds a missing closing parenthesis to example test (#967) * [SDK-core] Refactor SFError to follow more conventional Error object structure (#960) * Addresses several shortcomings in current worflows (mainly mainnet related) (#911) * Add back the serialized error to SFError's message (#978) * SDK-Core - isNativeAssetSuperToken query support (#970) * [SDK-core] Use `serialize-error` (#983) * fix handler.publish-release-packages (#985) * Add missing stringify (#988) * create operation from framework (#984) * Test Framework Created Operation + Remove isNativeAssetSuperToken from query (#989) * SDK-Core `isNativeAssetSuperToken` support (#992) * bump subgraph and sdk-core versions for dev (#998) * [spec-haskell] agreement framework refactored (#987) * Update ci.canary.yml (#1000) * [SDK-Core] Call App Action Support Added/Fixed CallAppAction BatchCall (#995) * SDK-Core 0.5.2 Patch Fix and Version Bump (#1001) * Update cd.hardhat-deployer-stable.create-release-drafts.yml (#1006) * Release hardhat deployer stable (#1009) * Add resolver and loader to deployer, add tests (#1011) * actions/setup-node cache property added (#1002) * Remove redundant deployments (#1014) * specify cache-dependency-path (#1018) * Ethereum 1.3.1 - for hardhat deployer update (#1016) * Fix release branch (#1024) * add tokenDecimals option to deploy-test-token.js (#1025) * Map indexId to IndexSubscription (#1026) * bump contract version, add test for loader (#1028) * New TestSuperApp: stream redirector wip (#1008) * #899 App Credit Rule CFA-2 (#945) * [Sk-core patch fix (#1035) * Adding Constant Flow Distribution Agreement etc. (#1017) * Remove pesky error messages that and update readme (#1037) * kwik patch (#1040) * Deprecate networks (#1032) * [TOGA] Added missing awaits (#1044) * [SDK-core] Don't wrap transaction errors with `SFError` & don't serialize a massive internal error into `SFError` message (#1046) * [SUBGRAPH] Update addresses.template.ts (#1047) * Remove examples folder (#1045) * [SDK-core] Specify name property for `SFError` (#1048) * [ETHEREUM-CONTRACTS] Add gnosisscan support (#1050) * Update README to link to examples repo (#1051) * Fix the precious slack bot message (#1053) * Update CHANGELOG.md (#1055) * [ETHEREUM-CONTRACTS] Gov: Convenience method for app registration keys and some cleanup (#1049) * remove hardhat deployer (#1057) * [ETHEREUM-CONTRACTS] CFA Agreement Forwarder (#982) * Remove MaticBridgedToken from monorepo (#1060) * [ETHEREUM-CONTRACTS] Add Custom Errors (#1043) * [ETHEREUM-CONTRACTS] yAcademy Gas Savings Applied (#1062) * bump solc to 0.8.16 (#1065) * Updating dependencies & dedup dev packages (#1064) * fix build (#1067) * [ETHEREUM-CONTRACTS] 1.4.0 Release (#1070) * [JS-SDK] 再见 JS-SDK (#1072) * Don't wrap SubgraphClient's errors with SFError (#1075) * [SDK-CORE] 0.5.6 Patch Fix (#1074) * Get Nix Pilled (#1073) * [SDK-CORE] 0.5.6 Patch Fix (#1074) * The Great TypeScript Refactor (#1069) * Bump terser in /packages/sdk-redux-examples/sdk-redux-react-typecript (#1078) * [ETHEREUM-CONTRACTS] _isPatricianPeriod Patch (#1080) * fix tests expect (#1082) * [ETHEREUM-CONTRACTS] backport 1.4.1 fixes (#1084) * [JS-SDK] Half undo deprecation (#1098) * [ETHEREUM-CONTRACTS] CFAv1Forwarder Fixes (#1094) * Fix links to the examples repo (#1100) * [ETHEREUM-CONTRACTS] CFA Hooks (#1099) * Fix subgraph testing: copy upstream docker compose file (#1109) * [ETHEREUM-CONTRACTS] SuperfluidFrameworkDeployer Additions (#1104) * Update of the nix flake tooling (#1108) * [ETHEREUM-CONTRACTS/SDK-CORE/SUBGRAPH] Use more Typechain capabilities (#1113) * [ETHEREUM-CONTRACTS/SDK-CORE] CFAv1 Forwarder Integration (#1118) * [ETHEREUM-CONTRACTS/SDK-CORE] Ethereum-Contracts 1.4.2 / SDK-Core 0.5.7 (#1119) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: elvijsTDL <77115130+elvijsTDL@users.noreply.github.com> Co-authored-by: David A. Divas <62566465+Daldiv@users.noreply.github.com> Co-authored-by: Miao ZhiCheng <miao@superfluid.finance> Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance> Co-authored-by: Joshua Trujillo <Jtriley15@gmail.com> Co-authored-by: Didi <git@d10r.net> Co-authored-by: saflamini <43142465+saflamini@users.noreply.github.com> Co-authored-by: FlacoJones <93455288+FlacoJones@users.noreply.github.com> Co-authored-by: Axe <ngmachado@users.noreply.github.com> Co-authored-by: Jonathan Gustafsson <jonathan@gustafsson.work> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sffn3va <114768934+sffn3va@users.noreply.github.com> Co-authored-by: tokdaniel <7677603+tokdaniel@users.noreply.github.com>
Why?
![image](https://user-images.githubusercontent.com/10894666/179945620-37362adf-e025-4b80-aaa9-712556343f5d.png)
JSON.stringify
is not sufficient for serializing errors:serialize-error
is a popular small library that handles error serialization: https://www.npmjs.com/package/serialize-error