Fix sdk initializations #946

saflamini · 2022-07-05T20:12:33Z

@JoshuaTrujillo15 @ngmachado

Outside of the 2 yarn.lock files which were changed, this one is pretty straightforward:

Updating some of the examples to use the new SDK Core
Removed networkName and dataMode from scripts and test suites

Let me know if anything looks off to you

@kasparkallas there is an issue though actually with one of the SDK Redux examples. Looks like maybe a peer dependency error? Can you take a look?

jtriley2p

Review

examples/tradeable-cashflow/artifacts

Please add this directory to the .gitignore.

jtriley2p

Examples

The @superfluid-finance/ethereum-contracts versions are mismatched.

Please align versions and do not use commit hashes for versioning.

IE:

"@superfluid-finance/ethereum-contracts": "1.2.3-dev.f94fdbb.0"

…id-finance/protocol-monorepo into fix_sdk_initializations

saflamini · 2022-07-06T14:23:21Z

@JoshuaTrujillo15 - changes have been made:

1-artifacts folder was moved to gitignore for tradeable cashflow
2-ethereum contracts versions have been bumped to 1.3

hellwolf · 2022-07-12T07:53:52Z

@JoshuaTrujillo15 could you have a look a gain?

jtriley2p · 2022-07-12T17:23:30Z

LGTM

hellwolf · 2022-07-13T07:51:26Z

Yes, let's approve and merge!

.

github-actions · 2022-07-13T09:49:26Z

XKCD Comic Relif

Link: https://xkcd.com/946

* Resolver Set + Workflow Modifications (#951) * add SetEvent to getAllEvents query (#953) * Subgraph 1.4.4 Release Bump | SDK-Core 0.4.5 Release Bump (#955) * Initialize logic contracts on deployment (using "castrate") (#841) * [SDK-core] Compile AJV validations (#954) * SDK-Core Build Fix (#963) * [EXAMPLES] Fix sdk initializations (#946) * bump sdk-core version to 0.5.0 (#964) Co-authored-by: elvijsTDL <77115130+elvijsTDL@users.noreply.github.com> Co-authored-by: David A. Divas <62566465+Daldiv@users.noreply.github.com> Co-authored-by: Miao ZhiCheng <miao@superfluid.finance> Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance> Co-authored-by: Joshua Trujillo <Jtriley15@gmail.com> Co-authored-by: Didi <git@d10r.net> Co-authored-by: saflamini <43142465+saflamini@users.noreply.github.com>

…structure (#960) * Refactor SFError to follow more conventional Error object structure * Change tsconfig's 'lib' to a more modern value * Fix tests * Rename error 'code' back to 'type' * Add fallback for Error.cause and assert it in tests * Better Subgraph error message * no more [object Object]] * Add 'caused by' to error message * set allowJs to true Sdk core v0.5.0 (#965) * Resolver Set + Workflow Modifications (#951) * add SetEvent to getAllEvents query (#953) * Subgraph 1.4.4 Release Bump | SDK-Core 0.4.5 Release Bump (#955) * Initialize logic contracts on deployment (using "castrate") (#841) * [SDK-core] Compile AJV validations (#954) * SDK-Core Build Fix (#963) * [EXAMPLES] Fix sdk initializations (#946) * bump sdk-core version to 0.5.0 (#964) Add back the serialized error to SFError's message Co-Authored-By: elvijsTDL <77115130+elvijsTDL@users.noreply.github.com> Co-Authored-By: David A. Divas <62566465+Daldiv@users.noreply.github.com> Co-Authored-By: Miao ZhiCheng <miao@superfluid.finance> Co-Authored-By: Kaspar Kallas <kaspar@superfluid.finance> Co-Authored-By: Joshua Trujillo <Jtriley15@gmail.com> Co-Authored-By: Didi <git@d10r.net> Co-Authored-By: saflamini <43142465+saflamini@users.noreply.github.com> Co-Authored-By: 0xdavinchee <0xdavinchee@gmail.com>

…structure (#960) (#977) * Refactor SFError to follow more conventional Error object structure * Change tsconfig's 'lib' to a more modern value * Fix tests * Rename error 'code' back to 'type' * Add fallback for Error.cause and assert it in tests * Better Subgraph error message * no more [object Object]] * Add 'caused by' to error message * set allowJs to true Sdk core v0.5.0 (#965) * Resolver Set + Workflow Modifications (#951) * add SetEvent to getAllEvents query (#953) * Subgraph 1.4.4 Release Bump | SDK-Core 0.4.5 Release Bump (#955) * Initialize logic contracts on deployment (using "castrate") (#841) * [SDK-core] Compile AJV validations (#954) * SDK-Core Build Fix (#963) * [EXAMPLES] Fix sdk initializations (#946) * bump sdk-core version to 0.5.0 (#964) Add back the serialized error to SFError's message Co-Authored-By: elvijsTDL <77115130+elvijsTDL@users.noreply.github.com> Co-Authored-By: David A. Divas <62566465+Daldiv@users.noreply.github.com> Co-Authored-By: Miao ZhiCheng <miao@superfluid.finance> Co-Authored-By: Kaspar Kallas <kaspar@superfluid.finance> Co-Authored-By: Joshua Trujillo <Jtriley15@gmail.com> Co-Authored-By: Didi <git@d10r.net> Co-Authored-By: saflamini <43142465+saflamini@users.noreply.github.com> Co-Authored-By: 0xdavinchee <0xdavinchee@gmail.com>

* Subgraph data integrity validation (#661) * Update dependencies (#930) * Disable public shaming during weekends and some more data to slack bot (#947) * Minor command update (#948) * ci.feature + ci.canary cleanup (#949) * [SDK-redux] Update example project references and add back WalletConnect (#942) * Create Hardhat Deployer (#950) * Update ci.canary.yml (#952) * Resolver Set + Workflow Modifications (#951) * add SetEvent to getAllEvents query (#953) * Subgraph 1.4.4 Release Bump | SDK-Core 0.4.5 Release Bump (#955) * Initialize logic contracts on deployment (using "castrate") (#841) * [SDK-core] Compile AJV validations (#954) * SDK-Core Build Fix (#963) * [EXAMPLES] Fix sdk initializations (#946) * bump sdk-core version to 0.5.0 (#964) * isNativeAssetSuperToken added to Token entity (#968) * Adds a missing closing parenthesis to example test (#967) * [SDK-core] Refactor SFError to follow more conventional Error object structure (#960) * Addresses several shortcomings in current worflows (mainly mainnet related) (#911) * Add back the serialized error to SFError's message (#978) * SDK-Core - isNativeAssetSuperToken query support (#970) * [SDK-core] Use `serialize-error` (#983) * fix handler.publish-release-packages (#985) * Add missing stringify (#988) * create operation from framework (#984) * Test Framework Created Operation + Remove isNativeAssetSuperToken from query (#989) * SDK-Core `isNativeAssetSuperToken` support (#992) * bump subgraph and sdk-core versions for dev (#998) * [spec-haskell] agreement framework refactored (#987) * Update ci.canary.yml (#1000) * [SDK-Core] Call App Action Support Added/Fixed CallAppAction BatchCall (#995) * SDK-Core 0.5.2 Patch Fix and Version Bump (#1001) * Update cd.hardhat-deployer-stable.create-release-drafts.yml (#1006) * Release hardhat deployer stable (#1009) * Add resolver and loader to deployer, add tests (#1011) * actions/setup-node cache property added (#1002) * Remove redundant deployments (#1014) * specify cache-dependency-path (#1018) * Ethereum 1.3.1 - for hardhat deployer update (#1016) * Fix release branch (#1024) * add tokenDecimals option to deploy-test-token.js (#1025) * Map indexId to IndexSubscription (#1026) * bump contract version, add test for loader (#1028) * New TestSuperApp: stream redirector wip (#1008) * #899 App Credit Rule CFA-2 (#945) * [Sk-core patch fix (#1035) * Adding Constant Flow Distribution Agreement etc. (#1017) * Remove pesky error messages that and update readme (#1037) * kwik patch (#1040) * Deprecate networks (#1032) * [TOGA] Added missing awaits (#1044) * [SDK-core] Don't wrap transaction errors with `SFError` & don't serialize a massive internal error into `SFError` message (#1046) * [SUBGRAPH] Update addresses.template.ts (#1047) * Remove examples folder (#1045) * [SDK-core] Specify name property for `SFError` (#1048) * [ETHEREUM-CONTRACTS] Add gnosisscan support (#1050) * Update README to link to examples repo (#1051) * Fix the precious slack bot message (#1053) * Update CHANGELOG.md (#1055) * [ETHEREUM-CONTRACTS] Gov: Convenience method for app registration keys and some cleanup (#1049) * remove hardhat deployer (#1057) * [ETHEREUM-CONTRACTS] CFA Agreement Forwarder (#982) * Remove MaticBridgedToken from monorepo (#1060) * [ETHEREUM-CONTRACTS] Add Custom Errors (#1043) * [ETHEREUM-CONTRACTS] yAcademy Gas Savings Applied (#1062) * bump solc to 0.8.16 (#1065) * Updating dependencies & dedup dev packages (#1064) * fix build (#1067) * [ETHEREUM-CONTRACTS] 1.4.0 Release (#1070) * [JS-SDK] 再见 JS-SDK (#1072) * Don't wrap SubgraphClient's errors with SFError (#1075) * [SDK-CORE] 0.5.6 Patch Fix (#1074) * Get Nix Pilled (#1073) * [SDK-CORE] 0.5.6 Patch Fix (#1074) * The Great TypeScript Refactor (#1069) * Bump terser in /packages/sdk-redux-examples/sdk-redux-react-typecript (#1078) * [ETHEREUM-CONTRACTS] _isPatricianPeriod Patch (#1080) * fix tests expect (#1082) * [ETHEREUM-CONTRACTS] backport 1.4.1 fixes (#1084) * [JS-SDK] Half undo deprecation (#1098) * [ETHEREUM-CONTRACTS] CFAv1Forwarder Fixes (#1094) * Fix links to the examples repo (#1100) * [ETHEREUM-CONTRACTS] CFA Hooks (#1099) * Fix subgraph testing: copy upstream docker compose file (#1109) * [ETHEREUM-CONTRACTS] SuperfluidFrameworkDeployer Additions (#1104) * Update of the nix flake tooling (#1108) * [ETHEREUM-CONTRACTS/SDK-CORE/SUBGRAPH] Use more Typechain capabilities (#1113) * [ETHEREUM-CONTRACTS/SDK-CORE] CFAv1 Forwarder Integration (#1118) * [ETHEREUM-CONTRACTS/SDK-CORE] Ethereum-Contracts 1.4.2 / SDK-Core 0.5.7 (#1119) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: elvijsTDL <77115130+elvijsTDL@users.noreply.github.com> Co-authored-by: David A. Divas <62566465+Daldiv@users.noreply.github.com> Co-authored-by: Miao ZhiCheng <miao@superfluid.finance> Co-authored-by: Kaspar Kallas <kaspar@superfluid.finance> Co-authored-by: Joshua Trujillo <Jtriley15@gmail.com> Co-authored-by: Didi <git@d10r.net> Co-authored-by: saflamini <43142465+saflamini@users.noreply.github.com> Co-authored-by: FlacoJones <93455288+FlacoJones@users.noreply.github.com> Co-authored-by: Axe <ngmachado@users.noreply.github.com> Co-authored-by: Jonathan Gustafsson <jonathan@gustafsson.work> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sffn3va <114768934+sffn3va@users.noreply.github.com> Co-authored-by: tokdaniel <7677603+tokdaniel@users.noreply.github.com>

Sam Flamini added 7 commits July 5, 2022 10:16

money router example

31a4f36

token spreader

aaecc92

budget nft / employment loan

3241afb

nftbillboard example

2f3e3d3

rewards dist example

cd745a8

stream in example

8522bcb

tradeable cashflow

64cc66b

saflamini requested a review from a team as a code owner July 5, 2022 20:12

Remove unused import

a6dcb4b

jtriley2p suggested changes Jul 5, 2022

View reviewed changes

jtriley2p previously requested changes Jul 5, 2022

View reviewed changes

Sam Flamini and others added 6 commits July 6, 2022 08:22

rm tcf artifacts folder... added to gitignore

64e6898

move all ethereum contracts versions to 1.3.0

77f0727

Merge branch 'dev' into fix_sdk_initializations

70c7868

updated contract versions

fe3e041

Merge branch 'fix_sdk_initializations' of https://github.com/superflu…

60658e0

…id-finance/protocol-monorepo into fix_sdk_initializations

update lockfiles for bash script

ff827c0

ngmachado requested a review from jtriley2p July 7, 2022 12:07

Sam Flamini added 4 commits July 12, 2022 11:22

updated sdk core in sdk redux ex

be8f522

fix merge conflict in package.json

e48617c

replace lockfile

0e5ddfc

update nftbillboard lockfile

4d34f95

Merge branch 'dev' into fix_sdk_initializations

20b1966

hellwolf approved these changes Jul 13, 2022

View reviewed changes

hellwolf merged commit c4c2ae9 into dev Jul 13, 2022

hellwolf deleted the fix_sdk_initializations branch July 13, 2022 09:49

hellwolf pushed a commit that referenced this pull request Jul 14, 2022

[EXAMPLES] Fix sdk initializations (#946)

7caa019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sdk initializations #946

Fix sdk initializations #946

saflamini commented Jul 5, 2022 •

edited

Loading

jtriley2p left a comment

jtriley2p left a comment

saflamini commented Jul 6, 2022

hellwolf commented Jul 12, 2022

jtriley2p commented Jul 12, 2022

hellwolf commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

Fix sdk initializations #946

Fix sdk initializations #946

Conversation

saflamini commented Jul 5, 2022 • edited Loading

jtriley2p left a comment

Choose a reason for hiding this comment

Review

jtriley2p left a comment

Choose a reason for hiding this comment

Examples

saflamini commented Jul 6, 2022

hellwolf commented Jul 12, 2022

jtriley2p commented Jul 12, 2022

hellwolf commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

XKCD Comic Relif

saflamini commented Jul 5, 2022 •

edited

Loading