Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKFLOWS] Update Nixpkgs Inputs & Update Node Dependencies #1390

Merged
merged 77 commits into from
Aug 11, 2023

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented May 6, 2023

  • update nixpkgs
  • update ghc
  • added node20, but keep node18 as default since subgraph local testing doesn't work with it.
  • remove certora
  • update node depenencies target minor versions.

Postponing to future PRs:

  • next steps:
    • graphql-request related major version update:
       @graphql-codegen/cli                    ^2.16.5  →  ^5.0.0
       @graphql-codegen/introspection           ^2.2.3  →  ^4.0.0
       @graphql-codegen/typed-document-node    ^2.3.13  →  ^5.0.1
       @graphql-codegen/typescript              ^2.8.8  →  ^4.0.1
       @graphql-codegen/typescript-operations  ^2.5.13  →  ^4.0.1
       ethers                                    5.7.2  →   6.7.0
       graphql-request                          ^4.3.0  →  ^6.1.0
      
    • node20-by-default update.
    • improve ethereum-contracts artifacts packaging (1.8.0 release).
    • improve metadata packaging, to support more framework.
  • aspirational next steps, keeping up with the Kardashians
    • pnpm migration.
    • sdk-core v2 with multi-frameworks support
  • probably never:
    • ethers-v6 update.

@github-actions
Copy link

github-actions bot commented May 6, 2023

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.82% 🎉

Comparison is base (9ecb24a) 87.39% compared to head (d4de3d7) 88.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1390      +/-   ##
==========================================
+ Coverage   87.39%   88.21%   +0.82%     
==========================================
  Files          91       90       -1     
  Lines        4481     4439      -42     
  Branches      186      186              
==========================================
  Hits         3916     3916              
+ Misses        519      477      -42     
  Partials       46       46              
Flag Coverage Δ
ethereum-contracts 97.66% <ø> (+1.87%) ⬆️
sdk-core 79.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/sdk-core/src/Host.ts 100.00% <ø> (ø)
packages/sdk-core/src/SuperToken.ts 100.00% <ø> (ø)
...ages/sdk-core/src/subgraph/subgraphQueryHandler.ts 14.63% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellwolf
Copy link
Contributor Author

merged merged, will address this one soon.

@hellwolf
Copy link
Contributor Author

All packages up to date, targeting minor version updates:

nix-shell$ yarn workspaces run check-updates 
yarn workspaces v1.22.19

> @superfluid-finance/solidity-semantic-money
yarn run v1.22.19
$ ncu --target minor
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/solidity-semantic-money/package.json
[====================] 1/1 100%

All dependencies match the minor package versions :)
Done in 1.09s.

> @superfluid-finance/ethereum-contracts
yarn run v1.22.19
$ ncu --target minor --dep prod,dev
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/ethereum-contracts/package.json
[====================] 22/22 100%

All dependencies match the minor package versions :)
Done in 3.56s.

> @superfluid-finance/metadata
yarn run v1.22.19
$ ncu --target minor
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/metadata/package.json

No dependencies.
Done in 0.83s.

> @superfluid-finance/js-sdk
yarn run v1.22.19
$ ncu --target minor --dep prod,dev
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/js-sdk/package.json
[====================] 9/9 100%

All dependencies match the minor package versions :)
Done in 2.63s.

> @superfluid-finance/sdk-core
yarn run v1.22.19
$ ncu --target minor --dep prod,dev
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/sdk-core/package.json
[====================] 17/17 100%

All dependencies match the minor package versions :)
Done in 6.69s.

> @superfluid-finance/sdk-redux
yarn run v1.22.19
$ ncu --target minor --dep prod,dev
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/sdk-redux/package.json
[====================] 10/10 100%

All dependencies match the minor package versions :)
Done in 2.40s.

> @superfluid-finance/subgraph
yarn run v1.22.19
$ ncu --target minor --dep prod,dev
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/subgraph/package.json
[====================] 10/10 100%

All dependencies match the minor package versions :)
Done in 2.68s.

> @superfluid-finance/hot-fuzz
yarn run v1.22.19
$ ncu --target minor
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/hot-fuzz/package.json
[====================] 2/2 100%

All dependencies match the minor package versions :)
Done in 1.11s.

> scheduler
yarn run v1.22.19
$ ncu --target minor
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/automation-contracts/scheduler/package.json
[====================] 3/3 100%

All dependencies match the minor package versions :)
Done in 1.09s.

> autowrap
yarn run v1.22.19
$ ncu --target minor
Using yarn
Checking /home/hellwolf/Projects/superfluid/protocol-monorepo.worktree/update_nix_flake_inputs/packages/automation-contracts/autowrap/package.json
[====================] 3/3 100%

All dependencies match the minor package versions :)
Done in 1.06s.
Done in 25.17s.

@hellwolf hellwolf marked this pull request as ready for review August 11, 2023 09:53
@hellwolf
Copy link
Contributor Author

https://github.com/superfluid-finance/protocol-monorepo/actions/runs/5831436532/job/15814866280?pr=1390

Create PR Artifact broken by lerna update. Let it be fore now, to be fixed.

Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellwolf hellwolf merged commit 6f34137 into dev Aug 11, 2023
@hellwolf hellwolf deleted the update_nix_flake_inputs branch August 11, 2023 16:34
@github-actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1390
https://xkcd.com/1390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants