[ETHEREUM-CONTRACTS] use registerAppWithKey #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## dev #1554 +/- ##
==========================================
+ Coverage 87.53% 96.35% +8.81%
==========================================
Files 91 41 -50
Lines 4389 2139 -2250
Branches 184 0 -184
==========================================
- Hits 3842 2061 -1781
+ Misses 503 78 -425
+ Partials 44 0 -44
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hellwolf
reviewed
Jul 31, 2023
| @@ -28,7 +28,8 @@ abstract contract SuperAppBaseFlow is ISuperApp { | |||
| ISuperfluid host_, | |||
| bool activateOnCreated, | |||
| bool activateOnUpdated, | |||
| bool activateOnDeleted | |||
| bool activateOnDeleted, | |||
| string memory registrationKey | |||
There was a problem hiding this comment.
breaking change..., but let's do it
hellwolf
approved these changes
Jul 31, 2023
|
oh codecov says no :) @0xdavinchee |
codecov is being a bully :( |
XKCD Comic RelifLink: https://xkcd.com/1554 |
hellwolf
pushed a commit
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use registerAppWithKey instead of registerApp as the latter is deprecated