Skip to content

fix: outside click for toolbar dropdown #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artem-harbour wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −2
Open

fix: outside click for toolbar dropdown #2174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9aa9ea
fix: outside click for toolbar dropdown
artem-harbour Feb 25, 2026
debdde5
fix: attach events via watch
artem-harbour Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 41 additions & 2 deletions packages/super-editor/src/components/toolbar/ButtonGroup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup>
import { computed, ref, h } from 'vue';
import { computed, ref, h, watch, onBeforeUnmount } from 'vue';
import ToolbarButton from './ToolbarButton.vue';
import ToolbarSeparator from './ToolbarSeparator.vue';
import OverflowMenu from './OverflowMenu.vue';
Expand All @@ -9,6 +9,7 @@ import { useHighContrastMode } from '../../composables/use-high-contrast-mode';
const emit = defineEmits(['command', 'item-clicked', 'dropdown-update-show']);

const toolbarItemRefs = ref([]);
const buttonGroupRef = ref(null);
const props = defineProps({
toolbarItems: {
type: Array,
Expand Down Expand Up @@ -210,10 +211,47 @@ const handleDropdownUpdateShow = (open) => {
}
emit('dropdown-update-show', open);
};

const handleDocumentPointerDown = (event) => {
if (!currentItem.value) return;

const target = event.target;
if (!(target instanceof HTMLElement)) return;

// Naive UI dropdown content is rendered in a portal outside the toolbar group.
// Treat it as "inside" so option clicks do not close the menu before selection.
if (target.closest('.sd-toolbar-dropdown-menu')) return;
if (buttonGroupRef.value?.contains(target)) return;

closeDropdowns();
};

const isCurrentItemExpanded = () => {
if (!currentItem.value) return false;
const { expand } = currentItem.value;
if (typeof expand === 'object' && expand !== null) return Boolean(expand.value);
return Boolean(expand);
};

watch(
isCurrentItemExpanded,
(isOpen) => {
if (isOpen) {
document.addEventListener('pointerdown', handleDocumentPointerDown, true);
} else {
document.removeEventListener('pointerdown', handleDocumentPointerDown, true);
}
},
{ immediate: true },
);

onBeforeUnmount(() => {
document.removeEventListener('pointerdown', handleDocumentPointerDown, true);
});
</script>

<template>
<div :style="getPositionStyle" class="button-group" role="group" @focus="handleFocus">
<div :style="getPositionStyle" class="button-group" role="group" @focus="handleFocus" ref="buttonGroupRef">
<div
v-for="(item, index) in toolbarItems"
:key="item.id.value"
Expand Down Expand Up @@ -249,6 +287,7 @@ const handleDropdownUpdateShow = (open) => {
() => ({
role: 'menu',
style: { fontFamily: props.uiFontFamily },
class: 'sd-toolbar-dropdown-menu',
})
"
:node-props="(option) => getDropdownAttributes(option, item)"
Expand Down
Loading