Conversation
artem-harbour
requested review from
VladaHarbour,
caio-pizzol and
harbournick
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9aa9ead40
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
looks good @artem-harbour
one small thing: GenericPopover.vue solves the same pointerdown click-outside problem but only attaches the listener while the popover is open (via a watch).
worth doing the same here with a watch on currentItem.value to stay consistent (unless it doesnt make sense)
feel free to merge after addressing this.
2 participants
No description provided.