Skip to content

Commit

Permalink
fix(ci): Lock cheerio version to 1.0.0-rc10 (#1687)
Browse files Browse the repository at this point in the history
* test: failing client tests

* Limit NodeJS to version 14.19.1

* fix: Slow npm install

* use latest NodeJS v14

* run `npm list`

* ignore `npm list` return code

* lock cheerio version
cheeriojs/cheerio#2545
  • Loading branch information
MarkLark86 authored May 25, 2022
1 parent 98ae7c1 commit 58c1860
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/ci-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x]
node-version: [14.x]
env:
INSTALL_NODE_MODULES: true
steps:
Expand Down Expand Up @@ -44,5 +44,6 @@ jobs:
run: ./scripts/ci-start-services.sh
# avoid file watch limit error
- run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
- run: npm list || true
- name: test
run: npm run test
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.
# Superdesk Planning
[![Build Status](https://travis-ci.org/superdesk/superdesk-planning.svg?branch=master)](https://travis-ci.org/superdesk/superdesk-planning)
[![Coverage Status](https://coveralls.io/repos/github/superdesk/superdesk-planning/badge.svg?branch=master)](https://coveralls.io/github/superdesk/superdesk-planning?branch=master)
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"@types/sinon": "^9.0.4",
"@typescript-eslint/parser": "2.6.1",
"btoa": "^1.1.2",
"cheerio": "1.0.0-rc.10",
"enzyme": "~3.11.0",
"enzyme-adapter-react-16": "^1.15.5",
"eslint": "6.6.0",
Expand Down
2 changes: 2 additions & 0 deletions scripts/ci-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ sudo apt-get -y install libxml2-dev libxmlsec1-dev libxmlsec1-openssl
python -m pip install --upgrade 'pip<21.3' wheel setuptools

if [ "$INSTALL_NODE_MODULES" == "true" ]; then
git config --global url."https://git@".insteadOf git://
npm install
fi

Expand All @@ -25,5 +26,6 @@ if [ "$E2E" == "true" ]; then
cd e2e/server
pip install -r requirements.txt
cd ../
git config --global url."https://git@".insteadOf git://
npm install
fi

0 comments on commit 58c1860

Please sign in to comment.