After the release of `v1.0.0-rc.11`, `Module parse failed: Unexpected token` occurs #2545

ygnoh · 2022-05-23T04:18:07Z

As the title says, since v1.0.0-rc.11 the below error occurs:

START:
ℹ ｢wdm｣: Compiled successfully.
ℹ ｢wdm｣: Compiling...
✖ ｢wdm｣: 
ERROR in ./node_modules/htmlparser2/lib/esm/index.js 59:9
Module parse failed: Unexpected token (59:9)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     return getFeed(parseDOM(feed, options));
| }
> export * as DomUtils from "domutils";
| // Old name for DomHandler
| export { DomHandler as DefaultHandler };
 @ ./node_modules/cheerio/lib/esm/index.js 11:0-68
 @ ./node_modules/enzyme/build/ReactWrapper.js
 @ ./node_modules/enzyme/build/index.js
 @ ./test.entry.js

I think it's a bug of cheerio, because it has been occurring since 3 days ago when the v1.0.0-rc.11 released.

Could you please look into this bug?

The text was updated successfully, but these errors were encountered:

krislavten · 2022-05-23T10:14:47Z

I have the same issue.

fb55 · 2022-05-23T10:26:04Z

The bundler is choking on export * as DomUtils from "domutils";. It seems like Webpack has supported the export * as ... syntax since ~2020 (see webpack/webpack@3cf8299), and an update should fix things. Alternatively, you could also force the bundler to pick up the CommonJS code that's still shipped with Cheerio.

For umijs/umi#8109: umijs seems to have switch to rollup afaict (at least I haven't been able to find a Webpack version), so there is a chance that updating some internal packages might do the trick?

Please let me know if this makes sense!

nicolashu · 2022-05-23T12:31:27Z

same issue

mike-lischke · 2022-05-23T13:49:38Z

People might not be able to upgrade a library, if that's actually brought in by other modules (e.g. via create-react-app). Changes that require upgrades of other libraries should always be accompanied by at least a minor version increase.

Locking package import to cheerio@1.0.0-rc.10 fixed the issue for me. But that should really not be needed! Please do such changes in another release that raise at least the minor version number, so they are not automatically picked up.

ygnoh · 2022-05-24T00:16:22Z

@mike-lischke Do you know a way to lock the package version on lerna?

In my project, enzyme is using cheerio. I couldn't find a way to lock the subdependecy of enzyme.
I tried npm-force-resolutions and overrides. But unfortunately lenra does not support them :(

ygnoh · 2022-05-24T06:34:08Z

I resolved this problem by declaring cheerio in devDependencies like:

  "devDependencies": {
    "cheerio": "=1.0.0-rc.3",
    ...

Hope this helps.

bindoon · 2022-05-24T12:07:46Z

I have the same issue. help me.

gladson1976 · 2022-05-24T13:03:01Z

I've tried the suggestion by @ygnoh, and it works fine in my local build.. but fails in the GitLab pipeline..
anyone have any ideas ?

yanglbme · 2022-05-24T14:24:41Z

lock the version in dependencies, like this doocs/md@551b07d

bindoon · 2022-05-24T14:27:40Z

it seems enzyme is using cherrio, how could I lock cherrio in enzyme

gladson1976 · 2022-05-25T02:09:30Z

it seems enzyme is using cherrio, how could I lock cherrio in enzyme

lock the cheerio version in your base package.json in dependencies or in devDependencies.. set it to "cheerio": "1.0.0-rc.10"

gladson1976 · 2022-05-25T02:10:30Z

lock the version in dependencies, like this doocs/md@551b07d

works fine when it is referenced in dependencies.. I had added in the devDependencies earlier..

cheeriojs/cheerio#2545

* test: failing client tests * Limit NodeJS to version 14.19.1 * fix: Slow npm install * use latest NodeJS v14 * run `npm list` * ignore `npm list` return code * lock cheerio version cheeriojs/cheerio#2545

ygnoh · 2022-05-25T09:30:02Z

@yanglbme @gladson1976

As a side note, enzyme recommends locking cheerio version as =1.0.0-rc.3.

enzymejs/enzyme#2559 (comment)

gladson1976 · 2022-05-25T11:06:09Z

@yanglbme @gladson1976

As a side note, enzyme recommends locking cheerio version as =1.0.0-rc.3.

enzymejs/enzyme#2559 (comment)

Yes, they do.. but since it was working fine for me till Friday with rc.10.. decided to go with it..

meeksfred · 2022-06-01T22:09:13Z

I resolved this problem by declaring cheerio in devDependencies like:
  "devDependencies": {
    "cheerio": "=1.0.0-rc.3",
    ...
Hope this helps.

Seriously a life saver, thank you.

Livshitz · 2022-06-13T10:30:07Z

+1 on the issue. Caused silent issues during builds. Was discovered only after an exhausting search as a dependency of a sub package, and most frustrating is that it was auto upgraded as rc11 treated as 'patch' (any default ^ package version will do that).
Semantic versioning isn't used by this project?

francois06 · 2022-06-13T16:03:59Z

1.0.0-rc.11 is an issue for me because of the ECMAScript Modules used in parse5-htmlparser2-tree-adapter 7.0.0 ...

The breaking change on parse5-htmlparser2-tree-adapter v7 is well documented :
https://github.com/inikulin/parse5/releases/tag/v7.0.0

This is a shame, that this package (cheerio) bump its dependencies (with major change) without a major change on its version .... It cost me hours of debugging -_-

How i landed here ?
I'm here because cheerio is a dependencies of an dependencies of MJML (that I use)!
(I remove node_modules and when I yarn install again because people do not handle correct semver everything explode)

Spend hours to find this =>
MJML > mjml-core > juice > "cheerio": "^1.0.0-rc.10" > parse5-htmlparser2-tree-adapter 7.0.0

Cheerio go to 1.0.0-rc.11 with parse5 v7 ==> all lib which use "cheerio": "^1.0.0-rc.10" will potentially blow up ...

So, please next time read the changelog before up the dep...

Meanwhile, here my fix :

if you use yarn, add these lines in package.json :

 "resolutions": {
    "cheerio": "1.0.0-rc.10",
    "parse5-htmlparser2-tree-adapter": "^6.0.0"
}

if you use npm, add these lines in package.json :

 "overrides": {
    "cheerio": "1.0.0-rc.10",
    "parse5-htmlparser2-tree-adapter": "^6.0.0"
}

Ressources
https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides
https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/

fb55 · 2022-06-16T10:37:07Z

parse5-htmlparser2-tree-adapter is a dual ESM and CJS module and shouldn't need this workaround.

ljharb · 2022-06-17T01:23:11Z

@fb55 the solution seems to be adding to "exports" the deep import enzyme is using.

Ganesh1991 · 2022-07-13T14:02:19Z

We getting the below issue while creating the build

./node_modules/html-to-react/node_modules/htmlparser2/lib/esm/index.js 67:9
Module parse failed: Unexpected token (67:9)
You may need an appropriate loader to handle this file type.
return getFeed(parseDOM(feed, options));
export * as DomUtils from "domutils"; // Old name for DomHandler
 export { DomHandler as DefaultHandler };

We tried updating both devDependencies and dependencies with "cheerio": "1.0.0-rc.3" But still we are getting same issue

Any suggestions?

fb55 · 2022-07-13T17:12:21Z

For everyone that is encountering this, have a look at @lukescott's great writeup on this issue. Relevant here:

A few solutions:

Upgrade to webpack 5

If you are using babel already, you can use @babel/plugin-proposal-export-namespace-from as mentioned in the webpack issue

You can target files/packages that use htmlparser2 and use resolve.mainFields in a rule to tell it to use main instead of module. For us doing this globally broke other things.

Lock the dependency to a version that still uses htmlparser2 v7.

I understand that it is annoying to have to work around this issue. Unfortunately, I don't see an easy way to work around this issue without negative side effects for users with modern tooling, meaning that this won't be fixed. Hope that makes sense!

ljharb · 2022-07-13T17:19:53Z

@fb55 i don't understand - all you have to do is add an entry to "exports", which won't have a negative impact on literally anybody.

Also, not everyone uses bundlers - enzyme runs in node, for example.

fb55 · 2022-07-13T17:23:32Z

@ljharb This is actually a separate issue 😄 — #2547 was fixed in #2601, which is included in the latest release. The issue here is that some old (but not too old) Webpack versions will struggle with export * as X from 'y' in the ESM module.

ljharb · 2022-07-13T17:27:02Z

Thanks for clarifying.

fwiw, recommending webpack 5 isn't a great idea, because it's broken - it doesn't polyfill node builtins by default.

* test: failing client tests * Limit NodeJS to version 14.19.1 * fix: Slow npm install * use latest NodeJS v14 * run `npm list` * ignore `npm list` return code * lock cheerio version cheeriojs/cheerio#2545

AnkurPrabhu · 2022-10-30T16:07:23Z

I resolved this problem by declaring cheerio in devDependencies like:
  "devDependencies": {
    "cheerio": "=1.0.0-rc.3",
    ...
Hope this helps.
Seriously a life saver, thank you.

yes the equal to sign "=" in the statement helped me solve my issue too thankyou

HondryTravis · 2022-11-06T12:33:11Z

god

vlad-frontdev · 2022-12-28T14:33:58Z

Lock the dependency to a version that still uses htmlparser2 v7

Just my 2 cents here basing on this comment. I'm not a cheerio but htmlparser2 user. For me locking htmlparser2 dependency to ~7.0.0 in package.json resolutions did the trick. If you're using Yarn you can try out this.

"resolutions": {
    ...
    "htmlparser2": "~7.0.0"
}

seanhexl · 2023-01-10T09:33:06Z

Lock the dependency to a version that still uses htmlparser2 v7

Just my 2 cents here basing on this comment. I'm not a cheerio but htmlparser2 user. For me locking htmlparser2 dependency to ~7.0.0 in package.json resolutions did the trick. If you're using Yarn you can try out this.
"resolutions": {
    ...
    "htmlparser2": "~7.0.0"
}

Can confirm this also worked for me (for me htmlparser2 is coming from sanitize-html, but we also use enzyme on its own). I was testing resolving cheerio and parse5-htmlparser2-tree-adapter, but I no longer need to - resolving htmlparser2 is enough by itself.

ItzLarz · 2023-01-13T22:39:23Z

I want to emphasize that this is not a cheerio issue. The issue lies in the newest version (8.0.1) htmlparser2 dependency, which has a file using syntax webpack doesn't understand. So to fix the issue, check if any of your dependencies are using that version of htmlparser2 by running:

npm ls htmlparser2

Revert all those dependencies to previous versions where they use htmlparser2 version 7.2.0 or less.

fb55 · 2023-01-22T14:01:47Z

To add to @ItzLarz: Modern versions of Webpack do understand the relevant syntax, so an upgrade will resolve this issue as well. See fb55/htmlparser2#1237 (comment) for more solutions.

We need to add the cozy-notifications webpack configuration. We also need to fix cheerio version to avoid "export * as DomUtils from "domutils";" error cheeriojs/cheerio#2545 (comment)

ygnoh changed the title ~~After the release of v1.0.0-rc.11, Module parse failed: Unexpected token occurs~~ After the release of v1.0.0-rc.11, Module parse failed: Unexpected token occurs May 23, 2022

ygnoh mentioned this issue May 23, 2022

[Bug] You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file umijs/umi#8109

Closed

ygnoh mentioned this issue May 24, 2022

Get an Error About export #2547

Closed

yanglbme referenced this issue in doocs/md May 24, 2022

fix: lock cheerio version

551b07d

fb55 mentioned this issue May 24, 2022

Cannot find module #2550

Closed

MarkLark86 added a commit to MarkLark86/superdesk-planning that referenced this issue May 25, 2022

lock cheerio version

e1e59f6

cheeriojs/cheerio#2545

MarkLark86 mentioned this issue May 25, 2022

fix(ci): Lock cheerio version to 1.0.0-rc10 superdesk/superdesk-planning#1687

Merged

kitsunde mentioned this issue May 27, 2022

Add new mapping for google play changes facundoolano/google-play-scraper#545

Closed

DeepVince mentioned this issue May 28, 2022

Building failed after cherrio was updated to 1.0.0-rc.11 Automattic/juice#402

Closed

lakerswgq mentioned this issue May 30, 2022

chore(*): lock cheerio version alibaba-fusion/next#3926

Merged

gdutwyg mentioned this issue Jun 1, 2022

编译成功后，运行nft-pc错误 fingerchar/fingernft#68

Closed

jcfranco mentioned this issue Jun 2, 2022

Revisit storybook build to handle latest cheerio version (CJS/ESM) Esri/calcite-design-system#4678

Closed

arcinself mentioned this issue Jun 7, 2022

Error due to cheerio dependency. brandon93s/html-table-to-json#12

Open

francois06 mentioned this issue Jun 13, 2022

Fixed cheerio version Automattic/juice#401

Merged

ChristopherChudzicki mentioned this issue Jun 17, 2022

Bump cheerio to @1.0.0-rc.11 enzymejs/enzyme#2561

Draft

atuchin-m mentioned this issue Jul 5, 2022

Bump WDP revision to address memory leak brave/brave-core#13943

Merged

25 tasks

fb55 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 13, 2022

This was referenced Aug 3, 2022

Module parse failed " export * as DomUtils from "domutils", "export * as foreignContent from './common/foreign-content.js'" #2669

Closed

syntax error in index.d.ts file. cheeriojs/cheerio-select#348

Closed

motou mentioned this issue Oct 28, 2022

chore(build): replace node-sass with sass carbon-design-system/devtools#261

Merged

1kvsn mentioned this issue Dec 13, 2022

打包报错 fb55/htmlparser2#1369

Closed

thompsonsj mentioned this issue Feb 21, 2023

fix(package.json): downgrade htmlparser2 for Webpack 4 compatibility thompsonsj/slate-serializers#49

Merged

asukaminato0721 mentioned this issue Mar 13, 2023

fix linux build CopyTranslator/CopyTranslator#558

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

After the release of `v1.0.0-rc.11`, `Module parse failed: Unexpected token` occurs #2545

After the release of `v1.0.0-rc.11`, `Module parse failed: Unexpected token` occurs #2545

ygnoh commented May 23, 2022 •

edited

Loading

krislavten commented May 23, 2022

fb55 commented May 23, 2022

nicolashu commented May 23, 2022

mike-lischke commented May 23, 2022 •

edited

Loading

ygnoh commented May 24, 2022 •

edited

Loading

ygnoh commented May 24, 2022 •

edited

Loading

bindoon commented May 24, 2022 •

edited

Loading

gladson1976 commented May 24, 2022

yanglbme commented May 24, 2022

bindoon commented May 24, 2022

gladson1976 commented May 25, 2022

gladson1976 commented May 25, 2022

ygnoh commented May 25, 2022 •

edited

Loading

gladson1976 commented May 25, 2022

meeksfred commented Jun 1, 2022

Livshitz commented Jun 13, 2022

francois06 commented Jun 13, 2022

fb55 commented Jun 16, 2022

ljharb commented Jun 17, 2022

Ganesh1991 commented Jul 13, 2022

fb55 commented Jul 13, 2022

ljharb commented Jul 13, 2022

fb55 commented Jul 13, 2022

ljharb commented Jul 13, 2022

AnkurPrabhu commented Oct 30, 2022

HondryTravis commented Nov 6, 2022

vlad-frontdev commented Dec 28, 2022 •

edited

Loading

seanhexl commented Jan 10, 2023

ItzLarz commented Jan 13, 2023 •

edited

Loading

fb55 commented Jan 22, 2023

After the release of v1.0.0-rc.11, Module parse failed: Unexpected token occurs #2545

After the release of v1.0.0-rc.11, Module parse failed: Unexpected token occurs #2545

Comments

ygnoh commented May 23, 2022 • edited Loading

krislavten commented May 23, 2022

fb55 commented May 23, 2022

nicolashu commented May 23, 2022

mike-lischke commented May 23, 2022 • edited Loading

ygnoh commented May 24, 2022 • edited Loading

ygnoh commented May 24, 2022 • edited Loading

bindoon commented May 24, 2022 • edited Loading

gladson1976 commented May 24, 2022

yanglbme commented May 24, 2022

bindoon commented May 24, 2022

gladson1976 commented May 25, 2022

gladson1976 commented May 25, 2022

ygnoh commented May 25, 2022 • edited Loading

gladson1976 commented May 25, 2022

meeksfred commented Jun 1, 2022

Livshitz commented Jun 13, 2022

francois06 commented Jun 13, 2022

fb55 commented Jun 16, 2022

ljharb commented Jun 17, 2022

Ganesh1991 commented Jul 13, 2022

fb55 commented Jul 13, 2022

ljharb commented Jul 13, 2022

fb55 commented Jul 13, 2022

ljharb commented Jul 13, 2022

AnkurPrabhu commented Oct 30, 2022

HondryTravis commented Nov 6, 2022

vlad-frontdev commented Dec 28, 2022 • edited Loading

seanhexl commented Jan 10, 2023

ItzLarz commented Jan 13, 2023 • edited Loading

fb55 commented Jan 22, 2023

After the release of `v1.0.0-rc.11`, `Module parse failed: Unexpected token` occurs #2545

After the release of `v1.0.0-rc.11`, `Module parse failed: Unexpected token` occurs #2545

ygnoh commented May 23, 2022 •

edited

Loading

mike-lischke commented May 23, 2022 •

edited

Loading

ygnoh commented May 24, 2022 •

edited

Loading

ygnoh commented May 24, 2022 •

edited

Loading

bindoon commented May 24, 2022 •

edited

Loading

ygnoh commented May 25, 2022 •

edited

Loading

vlad-frontdev commented Dec 28, 2022 •

edited

Loading

ItzLarz commented Jan 13, 2023 •

edited

Loading