Skip to content

fix(auth): return clear error on missing auth header and handle configurable tus sign path #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adityakk9031 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Open

fix(auth): return clear error on missing auth header and handle configurable tus sign path #1342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/http/plugins/jwt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ const jwtPlugin = fastifyPlugin<JWTPluginOptions>(
return
}

if (!request.jwt) {
request.jwtPayload = { role: 'anon' }
request.isAuthenticated = false
throw ERRORS.AccessDenied('Missing authorization header')
}

const { secret, jwks } = await getJwtSecret(request.tenantId)

try {
Expand Down
5 changes: 4 additions & 1 deletion src/http/routes/tus/lifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@ export async function onIncomingRequest(rawReq: Request, id: string, datastore:
req.upload.resources = [`${uploadID.bucket}/${uploadID.objectName}`]

// Handle signed url requests
if (req.url?.startsWith(`/upload/resumable/sign`)) {
if (
req.url?.startsWith(`${tusPath}${SIGNED_URL_SUFFIX}`) ||
req.url?.startsWith(`/upload/resumable${SIGNED_URL_SUFFIX}`)
) {
const signature = req.headers['x-signature']
if (!signature || (signature && typeof signature !== 'string')) {
throw ERRORS.InvalidSignature('Missing x-signature header')
Expand Down